Project

General

Profile

Actions
Copy link

Bug #4262

closed

mentat-enricher.py - When reloaded enrichment plugins should be able to retain their internal state

Added by Jan Mach over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jan Mach
Category:
Development - Core
Target version:
2.1
Start date:
08/13/2018
Due date:
% Done:

100%

Estimated time:
To be discussed:

Description

Currently all enrichment plugins are hard reloaded and their internal state is lost. This behavior was sufficient for all currently implemented plugins, however in some use cases this approach results in data and performance loss (for example in case of enrichment plugins which use internal caching mechanism).

Actions
Copy link
 #1

Updated by Pavel Kácha over 5 years ago

Wouldn't make more sense to not restart the whole daemon, but to give enricher plugins means to reload their data themselves? As far as I understand, design is event based, so plugins could schedule their own (and only their own) data reload as they see fit.

Actions
Copy link
 #2

Updated by Jan Mach over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Resolved this issue by not discarding the whole plugin instances during reload. Instead the plugin`s setup() method is called on each of the plugins. So it is up to the plugin to decide whether it is time to reload internal state.

Actions
Copy link

Also available in: Atom PDF