Project

General

Profile

Actions
Copy link

Feature #4486

closed

Generate chart toplists in JavaScript (aka. Igliar Button)

Added by Jan Mach almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Jan Mach
Category:
Development - GUI
Target version:
2.5
Start date:
12/20/2018
Due date:
% Done:

100%

Estimated time:
To be discussed:

Description

It would be preferable to generate chart toplists in JavaScript instead of in Python. When the toplists are generated in Python, user is not able to access the full information.

Related issues

Related to Mentat - Feature #4321: Implement new timeline-based visualisationsClosedJan Mach09/26/2018

Actions
Actions
Copy link
 #1

Updated by Jan Mach almost 6 years ago

  • Related to Feature #4321: Implement new timeline-based visualisations added
Actions
Copy link
 #2

Updated by Jan Mach almost 6 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 80

Lot of work on this issue was done within working on #4321.

Actions
Copy link
 #3

Updated by Jan Mach almost 6 years ago

  • Target version changed from 2.3 to 2.4
Actions
Copy link
 #4

Updated by Pavel Kácha almost 6 years ago

  • on precalculation
    • raise limit of top-n ips (to 100?)
    • drop limit for finite set values (Categories, maybe clients, maybe others?)
  • let server sends everything, Hawat shows what he wants
Additional possible customization:
  • optional time granularity for timeline charts
Actions
Copy link
 #5

Updated by Jan Mach over 5 years ago

  • Target version changed from 2.4 to 2.5
Actions
Copy link
 #6

Updated by Pavel Kácha over 5 years ago

  • Priority changed from Normal to High
Actions
Copy link
 #7

Updated by Jan Mach over 5 years ago

  • Subject changed from Generate chart toplists in JavaScript to Generate chart toplists in JavaScript (aka. Igliar Button)
Actions
Copy link
 #8

Updated by Jan Mach over 5 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Jan Mach to Pavel Kácha
  • % Done changed from 80 to 100

Attached patches solve this issue. Data truncation threshold is now set to 100. For certain statistical subkeys is defined truncation threshold to 1000. These keys currently are:

TRUNCATION_WHITELIST = {
    ST_SKEY_ANALYZERS:   True,
    ST_SKEY_CATEGORIES:  True,
    ST_SKEY_CATEGSETS:   True,
    ST_SKEY_DETECTORS:   True,
    ST_SKEY_DETECTORSWS: True,
    ST_SKEY_ABUSES:      True,
    ST_SKEY_COUNTRIES:   True,
    ST_SKEY_CLASSES:     True,
    ST_SKEY_SEVERITIES:  True,
}

In the web interface it is now possible to download unabridged full datasets in JSON and CSV. This is most easily demonstrated on per IP charts.

I now consider this issue to be resolved.

Actions
Copy link
 #9

Updated by Jan Mach over 5 years ago

Note: Currently it is possible to test this new feature only on our mentat-alt server.

Actions
Copy link
 #10

Updated by Pavel Kácha over 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Pavel Kácha to Jan Mach

I still see REST on Mentat-alt Events dashboard analyzers, categsets and others, is that ok?

Actions
Copy link
 #11

Updated by Jan Mach over 5 years ago

  • Assignee changed from Jan Mach to Pavel Kácha

Pavel Kácha wrote:

I still see REST on Mentat-alt Events dashboard analyzers, categsets and others, is that ok?

Yes, that is ok. The point of this task was to move toplist calculations from python code to frontend javascript and to provide means to access full data when necessary.

Actions
Copy link
 #12

Updated by Pavel Kácha over 5 years ago

  • Assignee changed from Pavel Kácha to Jan Mach

Jan Mach wrote:

Pavel Kácha wrote:

I still see REST on Mentat-alt Events dashboard analyzers, categsets and others, is that ok?

Yes, that is ok. The point of this task was to move toplist calculations from python code to frontend javascript and to provide means to access full data when necessary.

Mmmmkay.

However, when I click on graph CSV downloads (both terse and unabridged), nothing happens with following message in console:

Uncaught ReferenceError: loos_to_lols_tl is not defined
    at HTMLAnchorElement.<anonymous> (dashboard?dt_from=2019-06-06+00%3A00%3A00&dt_to=&submit=Hledat:2661)
    at HTMLAnchorElement.dispatch (jquery.min.js:2)
    at HTMLAnchorElement.y.handle (jquery.min.js:2)

Uncaught ReferenceError: loos_to_lols_tl is not defined
    at HTMLAnchorElement.<anonymous> (dashboard?dt_from=2019-06-06+00%3A00%3A00&dt_to=&submit=Hledat:2697)
    at HTMLAnchorElement.dispatch (jquery.min.js:2)
    at HTMLAnchorElement.y.handle (jquery.min.js:2)

(Also - correct spelling is "unabridged" with just one 'b' ).

Actions
Copy link
 #13

Updated by Jan Mach over 5 years ago

  • Assignee changed from Jan Mach to Pavel Kácha

Pavel Kácha wrote:

Jan Mach wrote:

Pavel Kácha wrote:

I still see REST on Mentat-alt Events dashboard analyzers, categsets and others, is that ok?

Yes, that is ok. The point of this task was to move toplist calculations from python code to frontend javascript and to provide means to access full data when necessary.

Mmmmkay.

However, when I click on graph CSV downloads (both terse and unabridged), nothing happens with following message in console:

[...]

[...]

Thank you for the report, it was a bug in JS library call and it should be fixed now.

(Also - correct spelling is "unabridged" with just one 'b' ).

Also thanks for this, it is fixed as well now.

Actions
Copy link
 #14

Updated by Pavel Kácha over 5 years ago

  • Status changed from Feedback to Closed
  • Assignee changed from Pavel Kácha to Jan Mach

Cool, thanks.

Actions
Copy link

Also available in: Atom PDF