Project

General

Profile

Actions

Feature #5065

closed

Update pynspect query semantic from "return bool" to "return bool deciding data"

Added by Pavel Kácha over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Development - Core
Target version:
Start date:
05/14/2019
Due date:
% Done:

100%

Estimated time:
To be discussed:

Description

Expression "ConnCount or FlowCount" returns simple True or False, where for greater pynspect versatility it would make sense to return value, which decided boolean expression, like for example python expressions.

There might be pitfalls though. Pynspect within Mentat often works on lists of lists, and list full of empty lists in this context makes sense as False. This semantics must stay, so other places, depending on this behaviour, must be identified and fixed.

Lib is very well covered by unit tests, so this will be good pointer (however, it should be verified that these corner cases are covered).

Actions #1

Updated by Jan Žerdík about 3 years ago

  • Assignee changed from Jan Žerdík to Jan Mach

https://github.com/honzamach/pynspect/pull/4/files
Waiting for accepting pull request

Actions #2

Updated by Jan Mach about 3 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

I have just merged the pull request to the base code, built WHL packages and updated dependencies in Mentat system. I will now build Mentat package, deploy it to the development server and watch for any possible problems.

Actions #3

Updated by Jan Mach about 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

Everything seems to work as expected, closing.

Actions

Also available in: Atom PDF