Actions
Bug #7556
closedCreated abuse groups can have invalid email address
Start date:
02/07/2022
Due date:
% Done:
0%
Estimated time:
To be discussed:
Description
When new abuse group is created, the name of the group is used as contact email address. If the name of the group is not a valid email address then mentat sends emails to invalid address during the reporting.
Updated by Jakub Judiny almost 2 years ago
- Status changed from New to In Progress
Updated by Rajmund Hruška almost 2 years ago
- Status changed from In Progress to In Review
- Target version changed from Backlog to 2.11
Updated by Rajmund Hruška almost 2 years ago
- Status changed from In Review to Feedback
I don't like the change on line 268 of file lib/mentat/reports/test_utils.py in 7087a10d:
self.assertEqual(reporting_settings.emails, (['abuse@cesnet.cz'], [], [], []))
to
self.assertEqual(reporting_settings.emails, ([], [], [], []))
I think the expected behaviour is to return (['abuse@cesnet.cz'], [], [], []) when asked for the emails.
This also shows the case which we need to think about: creating an abuse group without setting the reporting emails. If I see correctly, in your branch it is still possible to create an abuse group with a name which is not a valid email address and this group wouldn't have the correct emails for reporting.
Updated by Rajmund Hruška over 1 year ago
- Category set to Development - Database
- Status changed from Feedback to In Review
Updated by Rajmund Hruška over 1 year ago
- Status changed from In Review to Closed
Actions