Bug #7556: Created abuse groups can have invalid email address - Mentat - Homeproj: Redmine for CESNET

Actions

Copy link

Bug #7556

closed

Created abuse groups can have invalid email address

Added by Rajmund Hruška almost 3 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Jakub Judiny

Category:

Development - Database

Target version:

2.11

Start date:

02/07/2022

Due date:

% Done:

Estimated time:

To be discussed:

Description

When new abuse group is created, the name of the group is used as contact email address. If the name of the group is not a valid email address then mentat sends emails to invalid address during the reporting.

Actions

Copy link

Updated by Rajmund Hruška almost 3 years ago

To be discussed deleted (~~Yes~~)

Actions

Copy link

Updated by Jakub Judiny almost 2 years ago

Assignee set to Jakub Judiny

Actions

Copy link

Updated by Jakub Judiny almost 2 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Rajmund Hruška over 1 year ago

Status changed from In Progress to In Review
Target version changed from Backlog to 2.11

Actions

Copy link

Updated by Rajmund Hruška over 1 year ago

Status changed from In Review to Feedback

I don't like the change on line 268 of file lib/mentat/reports/test_utils.py in 7087a10d:

self.assertEqual(reporting_settings.emails, (['abuse@cesnet.cz'], [], [], []))

self.assertEqual(reporting_settings.emails, ([], [], [], []))

I think the expected behaviour is to return (['abuse@cesnet.cz'], [], [], []) when asked for the emails.

This also shows the case which we need to think about: creating an abuse group without setting the reporting emails. If I see correctly, in your branch it is still possible to create an abuse group with a name which is not a valid email address and this group wouldn't have the correct emails for reporting.

Actions

Copy link