Actions
Support #7642
closedUpgrade Flask-SQLAlchemy
Start date:
04/13/2023
Due date:
% Done:
0%
Estimated time:
To be discussed:
Description
Flask-SQLAlchemy is currently pinned to <3.0.0, because 3.0.0 removed sessionmaker, which is used in mentat.services.sqlstorage.py. Flask-SQLAlchemy now requires active application context for sessions and engines, so the approach to sessions in sqlstorage.py would have to change.
Another possible solution of this problem is to completely replace Flask-SQLAlchemy with SQLAlchemy (see issue #7545).
SQLAlchemy is also pinned to <2.0.0 because of Flask-SQLAlchemy, so it should also be upgraded in this issue.
Related issues
Updated by Jakub Judiny over 1 year ago
- Related to Support #7632: Mentat dependencies upgrade added
Updated by Jakub Judiny over 1 year ago
- Related to Task #7545: Review SQLAlchemy vs Flask-SQLAlchemy consolidation options added
Updated by Jakub Judiny about 1 year ago
- Related to Task #6205: Review encapsulation of SQLAlchemy and Psycopg2 DBALs added
Updated by Jakub Judiny about 1 year ago
- Status changed from In Progress to Resolved
Updated by Rajmund Hruška about 1 year ago
87b875d2 was merged into devel.
Now, flask_sqlalchemy is only used in lib/hawat/db.py. Isn't it also possible to replace it with sqlalchemy?
Updated by Rajmund Hruška about 1 year ago
- Status changed from Resolved to In Review
Updated by Rajmund Hruška about 1 year ago
- Status changed from In Review to Closed
- Target version changed from Backlog to 2.11
- To be discussed deleted (
Yes)
Actions