Project

General

Profile

Actions

Support #7642

closed

Upgrade Flask-SQLAlchemy

Added by Jakub Judiny over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
04/13/2023
Due date:
% Done:

0%

Estimated time:
To be discussed:

Description

Flask-SQLAlchemy is currently pinned to <3.0.0, because 3.0.0 removed sessionmaker, which is used in mentat.services.sqlstorage.py. Flask-SQLAlchemy now requires active application context for sessions and engines, so the approach to sessions in sqlstorage.py would have to change.

Another possible solution of this problem is to completely replace Flask-SQLAlchemy with SQLAlchemy (see issue #7545).

SQLAlchemy is also pinned to <2.0.0 because of Flask-SQLAlchemy, so it should also be upgraded in this issue.


Related issues

Related to Mentat - Support #7632: Mentat dependencies upgradeClosedJakub Judiny02/28/2023

Actions
Related to Mentat - Task #7545: Review SQLAlchemy vs Flask-SQLAlchemy consolidation optionsDeferredJakub Judiny01/06/2022

Actions
Related to Mentat - Task #6205: Review encapsulation of SQLAlchemy and Psycopg2 DBALsClosedRajmund Hruška01/24/2020

Actions
Actions #1

Updated by Jakub Judiny over 1 year ago

Actions #2

Updated by Jakub Judiny over 1 year ago

  • Related to Task #7545: Review SQLAlchemy vs Flask-SQLAlchemy consolidation options added
Actions #3

Updated by Jakub Judiny over 1 year ago

  • Assignee set to Jakub Judiny
Actions #4

Updated by Jakub Judiny over 1 year ago

  • Related to Task #6205: Review encapsulation of SQLAlchemy and Psycopg2 DBALs added
Actions #5

Updated by Jakub Judiny over 1 year ago

  • Status changed from New to In Progress
Actions #6

Updated by Jakub Judiny over 1 year ago

  • Status changed from In Progress to Resolved
Actions #7

Updated by Rajmund Hruška over 1 year ago

87b875d2 was merged into devel.

Now, flask_sqlalchemy is only used in lib/hawat/db.py. Isn't it also possible to replace it with sqlalchemy?

Actions #8

Updated by Rajmund Hruška over 1 year ago

  • Status changed from Resolved to In Review
Actions #9

Updated by Rajmund Hruška over 1 year ago

  • Status changed from In Review to Closed
  • Target version changed from Backlog to 2.11
  • To be discussed deleted (Yes)
Actions

Also available in: Atom PDF