Project

General

Profile

Actions
Copy link

Bug #3369

closed

Runlog file names are not sufficiently unique

Added by Jan Mach almost 8 years ago. Updated almost 4 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Rajmund Hruška
Category:
Development - Core
Target version:
Rejected
Start date:
03/21/2017
Due date:
% Done:

100%

Estimated time:
To be discussed:

Description

Names of the module runlog files go only to minute precission. There is a possibility, that the more of them may overwrite in case of multiple instances were launched at a same time. Make sure the names are unique by increasing time precission and/or adding pid.

Actions
Copy link
 #1

Updated by Jan Mach over 6 years ago

  • Target version changed from 2.0 to Backlog
Actions
Copy link
 #2

Updated by Rajmund Hruška about 4 years ago

  • Status changed from New to Resolved
  • Assignee changed from Jan Mach to Pavel Kácha
  • % Done changed from 0 to 100

My solution overrides the method from pizenkit, which determines the name of the file.

https://homeproj.cesnet.cz/projects/mentat/repository/mentat-ng/revisions/b3521f1c0fdb6ce58269f1254bf9783e481c91f7

Actions
Copy link
 #3

Updated by Pavel Kácha about 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Pavel Kácha to Rajmund Hruška

Wouldn't it make sense to send pull request directly to PyZenKit?

https://github.com/honzamach/pyzenkit

Actions
Copy link
 #4

Updated by Rajmund Hruška about 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Rajmund Hruška to Pavel Kácha

I made a PR to the original project repository.

Actions
Copy link
 #5

Updated by Rajmund Hruška about 4 years ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Pavel Kácha to Rajmund Hruška
  • % Done changed from 100 to 0
Actions
Copy link
 #6

Updated by Rajmund Hruška about 4 years ago

  • To be discussed set to Yes
Actions
Copy link
 #7

Updated by Rajmund Hruška about 4 years ago

  • To be discussed deleted (Yes)
Actions
Copy link
 #8

Updated by Rajmund Hruška almost 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Rajmund Hruška to Pavel Kácha
  • % Done changed from 0 to 100

The PR was approved and merged.

Actions
Copy link
 #9

Updated by Jan Mach almost 4 years ago

Built new version of Pyzenkit package (0.59) containing aforementioned fixes and increased version number for dependency in requirements file.

Actions
Copy link
 #10

Updated by Pavel Kácha almost 4 years ago

  • Assignee changed from Pavel Kácha to Rajmund Hruška

Just for clarification - changes are now in PyZenKit, so b3521f1c0fdb6ce58269f1254bf9783e481c91f7 (and related branch hruska-bugfix-#3369-runlog-names) is unnecessary and can be dropped?

Actions
Copy link
 #11

Updated by Pavel Kácha almost 4 years ago

  • Target version changed from Backlog to 2.8
Actions
Copy link
 #12

Updated by Jan Mach almost 4 years ago

  • Status changed from Resolved to Rejected
  • Target version changed from 2.8 to Rejected

Yes, this feature is now covered in PyZenKit library, so this patch is not necessary and can be discarded.

Actions
Copy link

Also available in: Atom PDF