Project

General

Profile

Actions

Bug #3369

closed

Runlog file names are not sufficiently unique

Added by Jan Mach about 7 years ago. Updated over 3 years ago.

Status:
Rejected
Priority:
Normal
Category:
Development - Core
Target version:
Start date:
03/21/2017
Due date:
% Done:

100%

Estimated time:
To be discussed:

Description

Names of the module runlog files go only to minute precission. There is a possibility, that the more of them may overwrite in case of multiple instances were launched at a same time. Make sure the names are unique by increasing time precission and/or adding pid.

Actions #1

Updated by Jan Mach almost 6 years ago

  • Target version changed from 2.0 to Backlog
Actions #2

Updated by Rajmund Hruška over 3 years ago

  • Status changed from New to Resolved
  • Assignee changed from Jan Mach to Pavel Kácha
  • % Done changed from 0 to 100

My solution overrides the method from pizenkit, which determines the name of the file.

https://homeproj.cesnet.cz/projects/mentat/repository/mentat-ng/revisions/b3521f1c0fdb6ce58269f1254bf9783e481c91f7

Actions #3

Updated by Pavel Kácha over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Pavel Kácha to Rajmund Hruška

Wouldn't it make sense to send pull request directly to PyZenKit?

https://github.com/honzamach/pyzenkit

Actions #4

Updated by Rajmund Hruška over 3 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Rajmund Hruška to Pavel Kácha

I made a PR to the original project repository.

Actions #5

Updated by Rajmund Hruška over 3 years ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Pavel Kácha to Rajmund Hruška
  • % Done changed from 100 to 0
Actions #6

Updated by Rajmund Hruška over 3 years ago

  • To be discussed set to Yes
Actions #7

Updated by Rajmund Hruška over 3 years ago

  • To be discussed deleted (Yes)
Actions #8

Updated by Rajmund Hruška over 3 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Rajmund Hruška to Pavel Kácha
  • % Done changed from 0 to 100

The PR was approved and merged.

Actions #9

Updated by Jan Mach over 3 years ago

Built new version of Pyzenkit package (0.59) containing aforementioned fixes and increased version number for dependency in requirements file.

Actions #10

Updated by Pavel Kácha over 3 years ago

  • Assignee changed from Pavel Kácha to Rajmund Hruška

Just for clarification - changes are now in PyZenKit, so b3521f1c0fdb6ce58269f1254bf9783e481c91f7 (and related branch hruska-bugfix-#3369-runlog-names) is unnecessary and can be dropped?

Actions #11

Updated by Pavel Kácha over 3 years ago

  • Target version changed from Backlog to 2.8
Actions #12

Updated by Jan Mach over 3 years ago

  • Status changed from Resolved to Rejected
  • Target version changed from 2.8 to Rejected

Yes, this feature is now covered in PyZenKit library, so this patch is not necessary and can be discarded.

Actions

Also available in: Atom PDF