Bug #5101
closed
Fix issue with default value for mail_to that leads to incorrect target email for mentat-reporter.py
Added by Jan Mach over 5 years ago.
Updated over 5 years ago.
Category:
Development - Core
Description
I was notified about he issue with mentat-reporter.py on our production server. Apparently some organizations were not receiving reports for some time. Investigate and fix it.
I have identified the source of the problem. There are default configurations in core/common.json.conf
configuration file for mail related stuff. The important thing is, that there is also a default value root
for mail_to
setting. The whole thing is designed to prevent Mentat system from accidentally spamming real world abuse contacts and this value takes overrides the values for abuse groups from database. Thanks to this design it is possible to simply set mail_to: "root"
as a default setting and you can be "sure" no email will be send to the world after default installation. When you want to enable sending reports in production environment, you have to either disable the default setting in core/common.json.conf
, or override it to mail_to: null
in mentat-reporter.py.conf
file.
I have included this piece of information into all relevant configuration files and documentation pages related to reporting configuration.
I have fixed the reporting configuration on our production server and I am currently waiting for some data to appear to verify, that emails are actually sent to target abuse contacts.
- Status changed from New to Feedback
- Assignee changed from Jan Mach to Pavel Kácha
- Priority changed from Immediate to High
- % Done changed from 0 to 90
Pavel, this design have caused us some problems. I think that by enhancing the documentation I have resolved them. I still think, that the default configuration should prevent from unwanted spamming. I still think, that a mechanism needs to be in place that enables administrators to override reporting settings coming from database and thus provides the ability to run development/testing instances of the system.
What is your opinion about this design decision (configuration file values take precedence over settings coming from database). Does it make sense to you too, or should it be changed to something else to be more clear and prone to errors?
Relevant documentation is here, does it make sense?
https://alchemist.cesnet.cz/mentat/doc/development/html/_doclib/reporting.html#reporting-configuration-for-administrators
P.S. At the time of this comment there still was no data to be reported, so I was not able to verify yet that the issue on our production system is resolved.
- % Done changed from 90 to 100
- Status changed from Feedback to Closed
Also available in: Atom
PDF