Project

General

Profile

Actions

Config #6949

closed

Merge inspector configs into one

Added by Pavel Kácha over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Low
Category:
Installation
Target version:
Start date:
01/22/2021
Due date:
% Done:

100%

Estimated time:
To be discussed:

Description

We now have three inspectors (two on alt) - first assigns classes, second does semantic checks, third sends selected events data to third party.

As found in #4214, we might simplify the config by merging them together. (Config file will get long, on the other hand less processes, less separate logs.)

Let's try this on mentat-alt first, if it goes without complications, we can go for it on mentat-hub. (We might still consider leaving third party sender separate, as sender problems are decoupled from saving to db.)


Related issues

Related to Mentat - Feature #4214: Nested rule chains in InspectorRejectedRajmund Hruška07/27/2018

Actions
Related to Mentat - Feature #6950: Consider implementing include in config filesRejected01/22/2021

Actions
Blocked by Mentat - Feature #6800: Rename _CESNET key to _Mentat (or make it configurable)ClosedRajmund Hruška11/19/2020

Actions
Actions #1

Updated by Pavel Kácha over 3 years ago

  • Related to Feature #4214: Nested rule chains in Inspector added
Actions #2

Updated by Pavel Kácha over 3 years ago

  • Related to Feature #6950: Consider implementing include in config files added
Actions #3

Updated by Rajmund Hruška over 3 years ago

  • Assignee changed from Rajmund Hruška to Pavel Kácha
  • To be discussed changed from No to Yes

I think it makes sense to merge #6800 to devel prior to merging those configs to one.

Actions #4

Updated by Pavel Kácha over 3 years ago

  • Blocked by Feature #6800: Rename _CESNET key to _Mentat (or make it configurable) added
Actions #5

Updated by Pavel Kácha over 3 years ago

  • To be discussed deleted (Yes)
Actions #6

Updated by Rajmund Hruška about 3 years ago

  • Status changed from New to Resolved
  • Assignee changed from Pavel Kácha to Rajmund Hruška
  • % Done changed from 0 to 100

There is a fallback action in the first config, which logs the case when none of the categories is set. However, in the second config there is a rule which also checks categories and logs possible errors. Therefore, I didn't include the fallback action from the first config in the new merged config.

Other than that, it seems to be working fine after using the merged config.

Actions #7

Updated by Rajmund Hruška about 3 years ago

  • To be discussed set to Yes

I checked the configs at mentat-alt and it seems that they don't differ from those tracked by git. For the first time, I tried building the new development version and it seems to work fine. I accidentally tagged the version bump commit with wrong issue, but from my understanding it shouldn't be a problem.

The buildbot finished successfully but when I checked the mentat-alt.cesnet.cz, I see that there is still the older version 2.7.25. Is there anything else I should do?

Actions #8

Updated by Pavel Kácha about 3 years ago

Rajmund Hruska wrote in #note-7:

I checked the configs at mentat-alt and it seems that they don't differ from those tracked by git. For the first time, I tried building the new development version and it seems to work fine. I accidentally tagged the version bump commit with wrong issue, but from my understanding it shouldn't be a problem.

The buildbot finished successfully but when I checked the mentat-alt.cesnet.cz, I see that there is still the older version 2.7.25. Is there anything else I should do?

apt-get update && apt-get upgrade

(and run migrations if necessary)

Buildbot have only created new packages in repo.

Actions #9

Updated by Rajmund Hruška about 3 years ago

I finally managed to update the mentat-alt and it seems to be working.

Actions #10

Updated by Rajmund Hruška about 3 years ago

  • To be discussed changed from Yes to No
Actions #11

Updated by Pavel Kácha about 3 years ago

  • Target version changed from Backlog to 2.8
Actions #12

Updated by Pavel Kácha about 3 years ago

  • Status changed from Resolved to In Review
Actions #13

Updated by Pavel Kácha about 3 years ago

From live discussion: We need to add specific version section into upgrade page of docs with heads-up note for admins. Also, we should add generic step into "Upgrading Mentat system" section (possibly between steps 5 and 6) about need to review possible configuration files changes.

Actions #14

Updated by Rajmund Hruška about 3 years ago

  • To be discussed changed from No to Yes

I removed the file paths containing inspector-b from packaging/debian/postinst. Should I merge it to devel and create a new version? I just updated mentat-alt after fixing the migration from #6800.

Actions #15

Updated by Pavel Kácha about 3 years ago

Rajmund Hruska wrote in #note-14:

I removed the file paths containing inspector-b from packaging/debian/postinst. Should I merge it to devel and create a new version? I just updated mentat-alt after fixing the migration from #6800.

I guess it should go into 2.8, however it concerns only package installation, so I guess new version/packages can wait until finishing 2.8 (with docs changes and so).

Actions #16

Updated by Pavel Kácha about 3 years ago

  • Status changed from In Review to Closed
Actions #17

Updated by Pavel Kácha almost 3 years ago

  • To be discussed deleted (Yes)
Actions

Also available in: Atom PDF