Config #6949
closed
Merge inspector configs into one
Added by Pavel Kácha almost 4 years ago.
Updated over 3 years ago.
Description
We now have three inspectors (two on alt) - first assigns classes, second does semantic checks, third sends selected events data to third party.
As found in #4214, we might simplify the config by merging them together. (Config file will get long, on the other hand less processes, less separate logs.)
Let's try this on mentat-alt first, if it goes without complications, we can go for it on mentat-hub. (We might still consider leaving third party sender separate, as sender problems are decoupled from saving to db.)
- Related to Feature #6950: Consider implementing include in config files added
- Assignee changed from Rajmund Hruška to Pavel Kácha
- To be discussed changed from No to Yes
I think it makes sense to merge #6800 to devel prior to merging those configs to one.
- Blocked by Feature #6800: Rename _CESNET key to _Mentat (or make it configurable) added
- To be discussed deleted (
Yes)
- Status changed from New to Resolved
- Assignee changed from Pavel Kácha to Rajmund Hruška
- % Done changed from 0 to 100
There is a fallback action in the first config, which logs the case when none of the categories is set. However, in the second config there is a rule which also checks categories and logs possible errors. Therefore, I didn't include the fallback action from the first config in the new merged config.
Other than that, it seems to be working fine after using the merged config.
- To be discussed set to Yes
I checked the configs at mentat-alt and it seems that they don't differ from those tracked by git. For the first time, I tried building the new development version and it seems to work fine. I accidentally tagged the version bump commit with wrong issue, but from my understanding it shouldn't be a problem.
The buildbot finished successfully but when I checked the mentat-alt.cesnet.cz, I see that there is still the older version 2.7.25. Is there anything else I should do?
Rajmund Hruska wrote in #note-7:
I checked the configs at mentat-alt and it seems that they don't differ from those tracked by git. For the first time, I tried building the new development version and it seems to work fine. I accidentally tagged the version bump commit with wrong issue, but from my understanding it shouldn't be a problem.
The buildbot finished successfully but when I checked the mentat-alt.cesnet.cz, I see that there is still the older version 2.7.25. Is there anything else I should do?
apt-get update && apt-get upgrade
(and run migrations if necessary)
Buildbot have only created new packages in repo.
I finally managed to update the mentat-alt and it seems to be working.
- To be discussed changed from Yes to No
- Target version changed from Backlog to 2.8
- Status changed from Resolved to In Review
From live discussion: We need to add specific version section into upgrade page of docs with heads-up note for admins. Also, we should add generic step into "Upgrading Mentat system" section (possibly between steps 5 and 6) about need to review possible configuration files changes.
- To be discussed changed from No to Yes
I removed the file paths containing inspector-b from packaging/debian/postinst. Should I merge it to devel and create a new version? I just updated mentat-alt after fixing the migration from #6800.
Rajmund Hruska wrote in #note-14:
I removed the file paths containing inspector-b from packaging/debian/postinst. Should I merge it to devel and create a new version? I just updated mentat-alt after fixing the migration from #6800.
I guess it should go into 2.8, however it concerns only package installation, so I guess new version/packages can wait until finishing 2.8 (with docs changes and so).
- Status changed from In Review to Closed
- To be discussed deleted (
Yes)
Also available in: Atom
PDF