Project

General

Profile

Actions

Bug #7607

closed

Awaited flag is removed inconsistently

Added by Pavel Kácha over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Development - Core
Target version:
Start date:
10/18/2022
Due date:
% Done:

0%

Estimated time:
To be discussed:
No

Description

When new user asks for an account and indicates which group they want to be member of, there are (at least) three ways to activate them:

  1. by context menu in users/NNN/show

    This removes wanted membership flag.

  1. by manually adding through users/NNN/update

    This does not remove the flag.

  1. by manually adding through groups/MMM/update

    Dunno.

Second scenario is thus wrong and we should fix it, and when at it we should check the third scenario (and possible others?) as well.


Related issues

Related to Mentat - Bug #7608: User activation updates changelog of just one objectClosedJakub Judiny10/18/2022

Actions
Actions #1

Updated by Pavel Kácha over 1 year ago

  • Related to Bug #7608: User activation updates changelog of just one object added
Actions #2

Updated by Jakub Judiny over 1 year ago

  • Assignee set to Jakub Judiny
Actions #3

Updated by Jakub Judiny over 1 year ago

  • Status changed from New to In Progress
Actions #4

Updated by Jakub Judiny over 1 year ago

It was decided that the best way to fix this is by adding a database trigger (SQLAlchemy event method).

The other possible solution discussed was a database model change: merging _asoc_group_members and _asoc_group_members_wanted to one table with extra column representing the status of the membership (active/wanted). It would require large changes in code, because there is no easy way to write it in SQLAlchemy without changing how group.members/group.wanted_members attributes behave.

Actions #5

Updated by Jakub Judiny over 1 year ago

  • Assignee changed from Jakub Judiny to Rajmund Hruška
Actions #6

Updated by Rajmund Hruška over 1 year ago

  • Status changed from In Progress to In Review
  • Assignee changed from Rajmund Hruška to Jakub Judiny
  • Target version changed from Backlog to 2.11

Jakub Judiny wrote in #note-5:

Rajmund Hruška please review the code, thank you.

(https://homeproj.cesnet.cz/projects/mentat/repository/mentat-ng?utf8=%E2%9C%93&rev=judiny-bugfix-%237607-awaited_flag_removal)

LGTM. Merged into devel and deployed on mentat-alt.

Actions #7

Updated by Rajmund Hruška about 1 year ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF