Task #7652
closedMake Pylint usable
0%
Description
Pylint now shows large amount of warnings. This makes us not use it after making some changes to code, which brings even more new warnings.
The goal is to split pylintrc-lib to two separate files: pedantic and non-pedantic one, and then fix most of the errors in non-pedantic pylint, so we can start using it again... at least in non-pedantic mode with some warnings ignored.
Related issues
Updated by Jakub Judiny 12 months ago
- Status changed from In Progress to Resolved
Updated by Rajmund Hruška 11 months ago
- Category set to Development - Tools
- Status changed from Resolved to In Review
- Target version changed from Backlog to 2.11
Merged into devel.
But it won't be that usable until #7654 is solved.
Updated by Rajmund Hruška 10 months ago
On GitLab we get a lot of C0411 warnings, e. g.
lib/hawat/blueprints/detectors/test/__init__.py:19:0: C0411: third party import "import hawat.const" should be placed before "from mentat.datatype.sqldb import DetectorModel" (wrong-import-order)
as seen in the log - https://gitlab.cesnet.cz/713/mentat/mentat/-/jobs/9847/raw.
This happens basically in every hawat file, because the imports from mentat precede those from hawat and mentat is considered a third party library. These warnings are not present on buildbot and my machine, though. I wonder why.
Updated by Pavel Kácha 10 months ago
- Related to Bug #7654: pylint job on buildbot takes too long added
Updated by Pavel Kácha 10 months ago
From 2023-06-22 meeting:
- would be nice to add test for 3.X SQLAlchemy with big fat warning to review the necessity for the patch close to the patching part of the Makefile
- then let's move this issue (or #7654?) into deferred (with similar note - to recheck on 3.X)
Updated by Rajmund Hruška 10 months ago
- Target version changed from 2.11 to Future
Updated by Rajmund Hruška 8 months ago
- Status changed from In Review to Closed
- Target version changed from Future to 2.12