Project

General

Profile

Task #3443

Code quality improvements

Added by Jan Mach almost 3 years ago. Updated over 1 year ago.

Status:
In Progress
Priority:
Low
Assignee:
Category:
Development - Core
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
To be discussed:
No

Description

Long running task to record work progress

Continually improve code quality by using following tools:


Related issues

Related to Mentat - Bug #4116: INSERT statement in eventstorage,py contains redundant whitespaceClosed06/01/2018

Associated revisions

Revision 5fdfa234 (diff)
Added by Jan Mach almost 3 years ago

Code quality improvements in executable files in bin project subdirectory.

Greatly improved code quality using pylint and pyflakes. All files now rank above 9 points with custom .pylintrc-bin file. Following exceptions were added to default pylint configuration:

  • line-too-long - I do not want to have calls to logging service spanning over multiple lines and distracting from code flow. I want them to be only single line, no matter how long, because it is not important. * bad-whitespace - I like to add additional whitespaces in places, where they should not be, mostly to align related items vertically, which in my opinion improves readability. * logging-format-interpolation - In Python3 I prefer string.format() to string % (args).

Additionally the pattern for module name validation was altered, because of our executable file naming policy (added suppot for '-' and '.' characters in name).

(Redmine issue: #3443)

Revision 52081d5e (diff)
Added by Jan Mach almost 3 years ago

Fix: Added missing global configuration.

Locally everything worked, but it would fail after building packages on build server. (Redmine issue: #3443)

Revision 8c6542f4 (diff)
Added by Jan Mach over 2 years ago

Migration, refactoring and code style unification to support latest PyZenKit and Pynspect libraries.

This huge update represents a lot of work on many parts of the system. After major upgrade in PyZenKit and Pynspect libraries it was necessary to bring this project up to date. There were many changes in the code, lot of refactoring and while all this was done, code quality was improved, documentation written and unit tests modified. Many of these changes simply make sure, that the code works with latest versions of both libraries. This commit is supposed to be a single major feature upgrade, after this only smaller commits will follow to polish this huge amount of work.

(Redmine issues: #3374, #1017, #3361, #3387, #3443)

Revision d9d19017 (diff)
Added by Jan Mach over 2 years ago

Unified implementation of Mentat module execution.

Code for each Mentat module now resides in valid Python module in mentat.module and all apropriate launcher scripts are very minmalistic. This is because names of executable files are not valid Python names for Python modules and this new approach will improve code testing and documentation processes. (Redmine issue: #3374, #3361, #3443)

Revision 56b6bbd5 (diff)
Added by Jan Mach over 2 years ago

Refactoring from mentat.plugin.script... to mentat.plugin.app...

It makes more sense to put all plugins, that can be used both in scripts and daemons to directory with a name that does not imply usage only in scripts. (Redmine issue: #3443)

Revision f9a84031 (diff)
Added by Jan Mach over 2 years ago

Added configuration file fo pylint tool for inspecting python modules (files in ./lib subdirectory).

(Redmine issue: #3443)

Revision 4f03339b (diff)
Added by Jan Mach over 2 years ago

Improved coding style of mentat.module.statistician with pylint.

(Redmine issue: #3443)

Revision 543c9a62 (diff)
Added by Jan Mach over 2 years ago

Checked the mentat.stats.idea module with pylint.

(Redmine issue: #3379,#3443)

Revision 57e4e1bd (diff)
Added by Jan Mach over 2 years ago

Checked, updated and unified coding style of mentat.daemon.component... Python modules.

Used pylint tool to check for violations of coding style. Minor documentation improvements. (Redmine issue: #3361,#3443)

Revision 3b2ceef5 (diff)
Added by Jan Mach over 2 years ago

Added download limit to GeoIP database fetching script.

GeoIP database downloads are limited to one download in 12 hours to protect third party service from any misconfiguration or overuse. (Redmine issue: #3443)

Revision b21c421a (diff)
Added by Jan Mach over 2 years ago

Improved utility script fetch-geoipdb.sh for fetching geolocation databases.

Added comments, added ability to receive and process command line arguments for better usability, few additional minor tweaks. (Redmine issue: #3443)

Revision 19585e7d (diff)
Added by Jan Mach over 2 years ago

Improved utility script fetch-negistry.sh for fetching geolocation databases.

Added comments, added ability to receive and process command line arguments for better usability, few additional minor tweaks. (Redmine issue: #3443)

Revision ab9a1426 (diff)
Added by Jan Mach over 2 years ago

Improved code quality with pyflakes.

Picked low hanging fruit by fixing almost all issues reported by pyflakes tool, with the exception of unit test files. (Redmine issue: #3443)

Revision 4725772f (diff)
Added by Jan Mach over 2 years ago

Code style improvements with pylint tool.

Removed all reported errors for library code reported by pylint, with additional fixes of minor problems. (Redmine issue: #3443)

Revision a5d79997 (diff)
Added by Jan Mach over 2 years ago

Code style improvements with pylint tool.

Fixed all pylint issues in mentat.geoip module. (Redmine issue: #3443)

Revision 51e02688 (diff)
Added by Jan Mach over 2 years ago

Fixed all issues in mentat.module.precache with pylint.

These changes fix broken build (Redmine issue: #3443,#3387).

Revision 19190e6b (diff)
Added by Jan Mach over 2 years ago

Added author and credits information into master init.py file in mentat package.

(Redmine issue: #3443)

Revision 6fede325 (diff)
Added by Jan Mach over 2 years ago

Fix: Fixed errors in hawat.db module detected by pylint, that broke the build.

(Redmine issue: #3443,#3387)

Revision e1ea1429 (diff)
Added by Jan Mach over 2 years ago

Fix: Fixed wrong quotes in database JSON configuration file.

(Redmine issue: #3443)

Revision d75c1c78 (diff)
Added by Jan Mach over 2 years ago

Improved the mentat.storage library.

  • Rewritten the StorageManager, so it now expects full Mentat core configuration tree.
  • Added couple of shortcut and helper methods.
  • Added database_info methods.
  • Increased documentation coverage.

(Redmine issue: #3443,#3361)

Revision 04f906af (diff)
Added by Jan Mach over 2 years ago

Fixed the whitespace output in main manu macro template.

(Redmine issue: #3443)

Revision 8f038e27 (diff)
Added by Jan Mach over 2 years ago

Refactoring: Renamed mentat.whois to mentat.services.whois.

(Redmine issue: #3443)

Revision 2480e518 (diff)
Added by Jan Mach over 2 years ago

Refactoring: Renamed mentat.geoip to mentat.services.geoip.

(Redmine issue: #3443)

Revision 191746e4 (diff)
Added by Jan Mach over 2 years ago

Code style improvements and lint error fixes with Pylint tool.

(Redmine issue: #3443)

Revision b323376d (diff)
Added by Jan Mach over 2 years ago

Fix: Fix for Pylint error on automated build system.

E:422,34: Module 'traceback’ has no 'TracebackException’ member (no-member)

(Redmine issue: #3443,#3387)

Revision 3c0bce23 (diff)
Added by Jan Mach over 2 years ago

Fix: Fixed many issues reported by Pyflakes tool.

(Redmine issue: #3443)

Revision 98f247ea (diff)
Added by Jan Mach over 2 years ago

Fix: Fixedaccess to invalid attribute in NetworkModel.

(Redmine issue: #3443)

Revision ed4f5a92 (diff)
Added by Jan Mach over 2 years ago

Fix: Fixed using of invalid metadata after commit 3a0c6d1.

Full path must be used instead of basename. (Redmine issue: #3443)

Revision 1856f3fa (diff)
Added by Jan Mach over 2 years ago

Fix: Fixed invalid declaration of static method.

(Redmine issue: #3443)

Revision 873501a8 (diff)
Added by Jan Mach over 2 years ago

Fix: Added initialization of SQL storage service into mentat-enricher.py main daemon component.

(Redmine issue: #3443)

Revision 521b23fa (diff)
Added by Jan Mach about 2 years ago

Minor code style improvements using pylint tool.

(Redmine issue: #3443)

Revision e9ffb84f (diff)
Added by Jan Mach about 2 years ago

Improvements in coding style using pylint tool.

(Redmine issue: #3443)

Revision d967fd4e (diff)
Added by Jan Mach about 2 years ago

Fix: Fixed a few coding style issues reported by pyflakes and pylint tools.

(Redmine issue: #3443)

Revision 1e39a17d (diff)
Added by Jan Mach about 2 years ago

Fix: Fixed bug in handling result from mentat.services.eventstorage...search_events

The search_events method was changed to return tuple, not scalar.

(Redmine issue: #3443)

Revision 2e182fa5 (diff)
Added by Jan Mach about 2 years ago

Fix: Fixed many issues including reported by Pylint tool.

The fixes include one build breaking error and many small code quality improvements. (Redmine issue: #3387,#3443)

Revision e9d7be27 (diff)
Added by Jan Mach about 2 years ago

Fix: Fixed minor bug and improved coding style.

(Redmine issue: #3443)

Revision b810d0cb (diff)
Added by Jan Mach about 2 years ago

Coding style improvements with pylint tool.

(Redmine issue: #3443)

Revision df8b6802 (diff)
Added by Jan Mach about 2 years ago

Improved event reporting library.

  • Updated documentation of the library classes and its methods.
  • Fixed minor issues reported by pylint utility.
  • Improved unit test coverage of the whole library.

(Redmine issue: #3361,#1017,#3443)

Revision 3ae644ab (diff)
Added by Jan Mach almost 2 years ago

Added valid maxDiff variable name from unit test framework to list of valid names in Pylint to globally ignore this warning.

(Redmine issue: #3443,#1017)

Revision 33f805c6 (diff)
Added by Jan Mach almost 2 years ago

Improved coding style in Hawat using Pylint tool.

(Redmine issue: #3443)

Revision 3929dffc (diff)
Added by Jan Mach almost 2 years ago

Improved coding style and content of flash messages of Hawat object management modules.

(Redmine issue: #3734,#3443)

Revision 97edfedd (diff)
Added by Jan Mach almost 2 years ago

Huge overhaul of Hawat`s Flask-based framework and all it`s modules.

This commit introduces huge amount of work that went into revision of existing Flask-based framework, on top of which the web interface and all of it`s modules are implemented. The process of registering modules and views into the application was greatly simplified (this will be used for further improvements of application menu). Code quality was improved using Pylint and Pyflakes tools. Documentation was improved. Many code features were refactored for performance, optimization and code style reasons. (Redmine issue: #3734,#3443)

Revision 5bc54067 (diff)
Added by Jan Mach almost 2 years ago

Code style improvements in mentat.datatype.sqldb library.

(Redmine issue: #3443)

Revision 0659b5e0 (diff)
Added by Jan Mach almost 2 years ago

Fix: Fixed minor bugs after previous commits.

Few of the unit tests were failing after previous changes. (Redmine issue: #3443)

Revision 368d8c47 (diff)
Added by Jan Mach almost 2 years ago

Implemented better algorithm in stop command of mentat-controller.py module.

The module now makes more and better attempts to stop all running Mentat modules. (Redmine issue: #3443)

Revision 6bd3822c (diff)
Added by Jan Mach almost 2 years ago

Refactoring: Renamed variable complist to modlist.

(Redmine issue: #3443)

Revision 6b0bee1d (diff)
Added by Jan Mach almost 2 years ago

Improved documentation and coding style of mentat-controller.py module.

(Redmine issue: #3361,#3443)

Revision d7d9ff5f (diff)
Added by Jan Mach almost 2 years ago

Fix: Fixed invalid attribute name for script return code in mentat.controller.py module.

Prior to this commit the controller module did not exit with appropriate return code. (Redmine issue: #3443)

Revision e1f8b66b (diff)
Added by Jan Mach over 1 year ago

Huge improvements in Hawat web interface.

This patch introduces huge amount of work related to Hawat web interface. I was just clicking through the interface and trying to improve everything that popped out at the moment. There are following improvements:

  • Enabled DataTable localication plugins.
  • Implemented common layout for object management views (list views).
  • Redesigned application menu implementation.
  • Enhanced application menu to support contextual item action menus in listing tables. All administration list views now use it to generate contextual action toolbars.
  • Menu object is now used even to generate breadcrumb menus.
  • Simplified working with view icons and their propagation into action menus.
  • Implemented AJAX spinner and used AJAX to fetch raw report data to web interface. There is stil a lot of room for improvements, the idea is for the user to be able to inteligently browse through the loaded data in some way.
  • Redesigned object administration views (users, groups, filters, networks).
  • Cleaned up list of built-in icons.
  • Improved web interface translations after the changes in this commit.
  • Fixed the bug in serving report data files.

(Redmine issue: #3734,#3443)

Revision 803c9769 (diff)
Added by Jan Mach over 1 year ago

Fix: Added missing parameter to function call.

(Redmine issue: #3443)

Revision ad2f8ac9 (diff)
Added by Jan Mach over 1 year ago

Refactoring: Renamed global Jinja variable hawat_view_title → hawat_this_view_title.

(Redmine issue: #3443)

Revision 28d03e53 (diff)
Added by Jan Mach over 1 year ago

Unified display of undisclosed values in event search result table.

(Redmine issue: #3443)

Revision 7dc2ba09 (diff)
Added by Jan Mach over 1 year ago

Moved as much code from all views based on HawatSearchView to base class and common Jinja template.

(Redmine issue: #3443)

Revision 5377e30a (diff)
Added by Jan Mach over 1 year ago

Fix: Fixed bug possibly leading to HTTP 500 error.

(Redmine issue: #3443)

Revision e487ad82 (diff)
Added by Jan Mach over 1 year ago

Inherited report search form from hawat.forms.BaseSearchForm to make use of common code.

(Redmine issue: #3443)

Revision b60ae08c (diff)
Added by Jan Mach over 1 year ago

Used new version of PyZenKit library to implement more gracefull shutdown od daemons.

The PyZenKit library now enables daemons to perform more gracefull shutdown by letting them funish up current work. All that needed to be done in the code of Mentat was to forbid filer daemon component to fetch any new messages from the queue when the daemon is in shutdown process.

(Redmine issue: #3443)

Revision 6d611c5a (diff)
Added by Jan Mach over 1 year ago

Enabled new periodical runlog saving feature implemented in latest PyZenKit library.

This feature can be now used for periodical monitoring of processing performance of each daemon module. (Redmine issue: #3443)

Revision 41a66ff8 (diff)
Added by Jan Mach over 1 year ago

Improved coding style and log messages of the most important deamon components.

Code of the most important daemon components was improved using Pylint and Pyflakes tools. Additionally text and level of the outputted log messages was tweaked for better results. (Redmine issue: #3443)

Revision 35524f5d (diff)
Added by Jan Mach over 1 year ago

Fix: Added missing constant definition.

(Redmine issue: #1017,#3443)

Revision 7204ad02 (diff)
Added by Jan Mach over 1 year ago

Fix: Fixed broken committer daemon module.

Added missing value to event map definition. (Redmine issue: #1017,#3443)

Revision df36d3f9 (diff)
Added by Jan Mach over 1 year ago

Fix: Fixed syntax error.

(Redmine issue: #3443)

Revision 4b138080 (diff)
Added by Jan Mach over 1 year ago

Fix: Hardened metadata migration script to be more resistent to missing 'affiliations’ attribute in user account MongoDB object.

(Redmine issue: #3443)

Revision e3547a6f (diff)
Added by Jan Mach over 1 year ago

Fix: Fixed broken report message display.

(Redmine issue: #3443)

Revision 66810dad (diff)
Added by Jan Mach over 1 year ago

Added '&' escaping to report message display view.

For some reason the obvious solution “item.message | escape | ...” did not work and the escape filter escaped everything that was being appended with the later filters, which resulted in mangled report message. (Redmine issue: #3443)

Revision 582c2558 (diff)
Added by Jan Mach over 1 year ago

Added absolute path to SQL database migration utility script.

(Redmine issue: #3443)

Revision a767bb3c (diff)
Added by Jan Mach over 1 year ago

Fix: Fixed or silenced few Pylint errors and warnings in Hawat base library.

(Redmine issue: #3443)

Revision 805e5018 (diff)
Added by Jan Mach over 1 year ago

Moved validators to common library.

(Redmine issue: #3443)

Revision 6b17e4d9 (diff)
Added by Jan Mach over 1 year ago

Fix: Addedd missing argument propagation into submenu in menu entry filtering.

(Redmine issue: #3443)

Revision 62495d79 (diff)
Added by Jan Mach over 1 year ago

Minor tweaks in event detail view template.

(Redmine issue: #3443)

Revision 80af4ce7 (diff)
Added by Jan Mach over 1 year ago

Improved coding style in mentat.services.test_eventstorage test module.

(Redmine issue: #1017,#3443)

Revision 2c9fb952 (diff)
Added by Jan Mach over 1 year ago

Improved coding style, unit tests and doumentation of IDEA message enrichment plugins.

(Redmine issue: #4262,#1017,#3443)

Revision 7c94b144 (diff)
Added by Jan Mach over 1 year ago

Fix: Removed component identification from enrichment plugin log lines.

The component identification is not available through daemon object. (Redmine issue: #4262,#3443)

Revision f7d5114b (diff)
Added by Jan Mach over 1 year ago

Improvements in coding style, documentation and unit tests of mentat-enricher.py module.

(Redmine issue: #4213,#1017,#3361,#3443)

Revision ebcbabcc (diff)
Added by Jan Mach over 1 year ago

Improved documentation and coding style of mentat.stats.idea module.

(Redmine issue: #3361,#3443)

Revision 58a95ad5 (diff)
Added by Jan Mach over 1 year ago

Unified design of timeline, event and report dashboard forms.

(Redmine issue: #3443)

Revision 9bc32c93 (diff)
Added by Jan Mach over 1 year ago

Moved the inclusion of chart libraries to the common layout template.

Unnecessary optimalization. (Redmine issue: #4321,#3443)

Revision 3b3d95cf (diff)
Added by Jan Mach about 1 year ago

Fixed one minor Pylint warning.

(Redmine issue: #3443)

Revision be5176b4 (diff)
Added by Jan Mach about 1 year ago

Updated third party libraries.

(Redmine issue: #3443)

Revision 884cdf8d (diff)
Added by Jan Mach about 1 year ago

Refactoring: Replaced the gettext() with shorter _() in macro Jinja2 files.

(Redmine issue: #3443)

Revision 66b711e8 (diff)
Added by Jan Mach about 1 year ago

Improved coding style in migration environment script.

(Redmine issue: #4230,#3443)

Revision 999a02fb (diff)
Added by Jan Mach about 1 year ago

Minor coding style improvements in Hawat authentication code and modules.

Changed coding style to match the rest of the project, added some more configuration options for tweaking authentication modules, like default login/logou redirection targets. (Redmine issue: #3443)

Revision 14be3783 (diff)
Added by Jan Mach about 1 year ago

Moved the built-in index page into separate pluggable module.

To be more consistent with the rest of the system this patch moves the built-in index page to separate pluggable module. There is still room for improvement by using Jinja2 macro for rendering breadcrumb navigation. Currently it is used only within part of the system. (Redmine issue: #4220,#3443)

Revision 1f3496e3 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HTMLViewMixin to HTMLMixin.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 719ab500 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed AJAXViewMixin to AJAXMixin.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision bf0f40df (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed SQLAlchemyViewMixin to SQLAlchemyMixin.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 6669f5a5 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed PsycopgViewMixin to PsycopgMixin.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 61ff9767 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatBaseView to BaseView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 8fe2cee5 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatFileNameView to FileNameView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision ce83913c (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatFileIdView to FileIdView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision a0f4bde5 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatRenderableView to RenderableView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision a80fad36 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatSimpleView to SimpleView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 3a30215d (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatSearchView to SearchView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 863ac281 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemListView to ItemListView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision c37351b5 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemShowView to ItemShowView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision e838ebef (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemActionView to ItemActionView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 0f62f772 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemCreateView to ItemCreateView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 5a3bf375 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemUpdateView to ItemUpdateView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision ff8503f8 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemDeleteView to ItemDeleteView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 95237232 (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemChangeView to ItemChangeView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision f9e2abea (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemEnableView to ItemEnableView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 15f4f29e (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed HawatItemDisableView to ItemDisableView.

The original name was unnecessarily long. (Redmine issue: #3443)

Revision 870128e5 (diff)
Added by Jan Mach about 1 year ago

Huge amount of coding style improvements.

I have used Pylint tool to fix easily fixable issues. (Redmine issue: #3443)

Revision 72b7e4dc (diff)
Added by Jan Mach about 1 year ago

Rewritten and enhanced the Hawat logging setup.

The logging setup is now more capable and configurable. (Redmine issue: #4216,#3443)

Revision e1ea5d6a (diff)
Added by Jan Mach about 1 year ago

Moved the function higher up in the class definition.

(Redmine issue: #3443)

Revision bf4174c4 (diff)
Added by Jan Mach about 1 year ago

Moved the flask_mail initializations to separate module.

This was done to better decouple the library code. I have also added logging of subject and recipients for each email and added makefile target for launching development mail server. (Redmine issue: #3443)

Revision ea70ad1f (diff)
Added by Jan Mach about 1 year ago

Refactoring: Renamed 'level’ parameter for flash messages to 'category’.

It is called 'category’ everywhere in the Flask, so we should call it same. (Redmine issue: #3443)

Revision 15cfc12c (diff)
Added by Jan Mach about 1 year ago

Fix: Unit tests must run with APP_ROOT_PATH set.

(Redmine issue: #1017,#3443)

Revision 07a2d835 (diff)
Added by Jan Mach about 1 year ago

Moved local lightweight chroot bootstrap to separate script file.

(Redmine issue: #3443,#3387)

Revision 6188c75d (diff)
Added by Jan Mach about 1 year ago

Improved codign style of test module with Pylint.

(Redmine issue: #3443)

Revision c682ea63 (diff)
Added by Jan Mach about 1 year ago

Fix: Fixed DemoFetcherScript demonstration and unit test.

(Redmine issue: #1017,#3443)

Revision b45077af (diff)
Added by Jan Mach about 1 year ago

Removed configuration files for demonstration installations.

All configuration files should by default be in a most optimal state for quick deployment without any tinkerink. The demo configuration files are redundant and increase management overhead, there is one more place that needs to be updated. (Redmine issue: #3443)

Revision f854da1c (diff)
Added by Jan Mach about 1 year ago

Moved all precompiled regular expressions for Hawat to hawat.const module.

(Redmine issue: #3443)

Revision 96894e03 (diff)
Added by Jan Mach about 1 year ago

Fixed broken daemon component unit tests.

Changes were necessary after previous commits. (Redmine issue: #1017,#3443)

Revision e14508c3 (diff)
Added by Jan Mach 11 months ago

Included simple benchmark file for measuring performance of statistical calculations for IDEA messages.

Current version is a very simple script with a huge room for improvements. (Redmine issue: #3443,#1017)

Revision 970e54d6 (diff)
Added by Jan Mach 8 months ago

Refactoring: Renamed gettext() call to shorter form _().

(Redmine issue: #3443)

Revision c7026a2f (diff)
Added by Jan Mach 5 months ago

Fix: Fixed unit test broken on Python3.7.

(Redmine issue: #1017,#3443,#3387)

Revision dd935415 (diff)
Added by Jan Mach 4 months ago

Fix: Fixed devtools-config view.

(Redmine issue: #3443)

Revision c0bdc0c3 (diff)
Added by Jan Mach 4 months ago

Made dbstatus views for displaying current queries more bulletproof.

(Redmine issue: #3443)

Revision 09a72bed (diff)
Added by Jan Mach 2 months ago

Added logfile logging for BAD REQUEST HTTP errors.

To better understand what went wrong with the request. (Redmine issue: #3443)

Revision c913e7c5 (diff)
Added by Jan Mach about 1 month ago

Code style improvements with PyLint.

(Redmine issue: #3443)

Revision 1486182f (diff)
Added by Jan Mach about 1 month ago

Refactoring: HawatApp → VialApp.

(Redmine issue: #3443)

Revision d6fb59b9 (diff)
Added by Jan Mach about 1 month ago

Refactoring: Renamed HawatBlueprint → VialAppBlueprint, HawatUtils → VialAppUtils, code style improvements.

(Redmine issue: #3443)

Revision 578c842e (diff)
Added by Jan Mach about 1 month ago

Fix: Fixed invalid attribute name after previous refactoring.

(Redmine issue: #3443)

Revision 263432fc (diff)
Added by Jan Mach about 1 month ago

Refactoring: Renamed VialApp* simply to Vial*

(Redmine issue: #3443)

Revision 0be8b86f (diff)
Added by Jan Mach 28 days ago

Split Vial application skeleton into its own Python package.

(Redmine issue: #3443)

Revision 041ecb49 (diff)
Added by Jan Mach 28 days ago

Fix: Fixed minor PyLint warnings.

(Redmine issue: #3443)

Revision 556887b0 (diff)
Added by Jan Mach 28 days ago

Fix: Fixed usage of invalid module name.

(Redmine issue: #3443)

Revision e91afbbf (diff)
Added by Jan Mach 28 days ago

Fix: Fixed database migrations for web interface.

(Redmine issue: #3443)

Revision 5f1bf92d (diff)
Added by Jan Mach 26 days ago

Fix: Fixed warnings reported by PyLint.

(Redmine issue: #3443)

Revision a8f53676 (diff)
Added by Jan Mach 26 days ago

Fix: Fixed some coding style warnings reported by PyLint.

(Redmine issue: #3443)

Revision 47b32a1e (diff)
Added by Jan Mach 25 days ago

Added support for code test coverage calculations.

(Redmine issue: #3443)

Revision 96a8acda (diff)
Added by Jan Mach 25 days ago

Fix: Fixed deprecation warning.

(Redmine issue: #3443)

Revision 4ce829ab (diff)
Added by Jan Mach 25 days ago

Fix: Fixed duplicate method name.

(Redmine issue: #3443)

Revision d5434894 (diff)
Added by Jan Mach 25 days ago

Fix: Fixed minor warning reported by PyLint.

(Redmine issue: #3443)

Revision 86dc4955 (diff)
Added by Jan Mach 25 days ago

Fix: Added missing import.

(Redmine issue: #3443)

Revision 3deac0bc (diff)
Added by Jan Mach 25 days ago

Fix: Paths to translation directories must be relative to APP_ROOT_PATH.

(Redmine issue: #3443)

Revision 683a6b75 (diff)
Added by Jan Mach 25 days ago

Changed default value of EXPLAIN_TEMPLATE_LOADING = False for DevelopmentConfig.

Display was cluttered, developer should turn it on only when necessary. (Redmine issue: #3443)

Revision ca814018 (diff)
Added by Jan Mach 24 days ago

Added the ability to register models into the Vial application.

Now it is possible to use application models throughout the application without the knowledge of the exact model class name. (Redmine issue: #3443)

Revision a7b28ab6 (diff)
Added by Jan Mach 24 days ago

Imporved coding style of hawat.blueprint.auth_dev package.

  • Removed unnecessary documentation and comments.
  • Made use of new model registration feature to access user and changelog models.

(Redmine issue: #3443)

Revision 6ac8396c (diff)
Added by Jan Mach 24 days ago

Improved coding style of hawat.blueprint.auth_dev package.

  • Removed unnecessary documentation and comments.
  • Made use of new model registration feature to access user and changelog models.

(Redmine issue: #3443)

Revision fd5e6fb1 (diff)
Added by Jan Mach 22 days ago

Changed PyLint configurations to be less restrictive.

(Redmine issue: #3443)

Revision 86f35b15 (diff)
Added by Jan Mach 22 days ago

Changed signature of get_item_form() method of vial.view.ItemCreateView.

(Redmine issue: #3443)

Revision 67c0ca11 (diff)
Added by Jan Mach 22 days ago

Added missing method to view class.

(Redmine issue: #3443)

Revision 11a5d90c (diff)
Added by Jan Mach 22 days ago

Improved coding style of hawat.blueprint.auth_env package.

  • Removed unnecessary documentation and comments.
  • Made use of new model registration feature to access user and changelog models.

(Redmine issue: #3443)

Revision a3eed964 (diff)
Added by Jan Mach 22 days ago

Improved coding style of hawat.blueprint.auth_pwd package.

  • Removed unnecessary documentation and comments.
  • Made use of new model registration feature to access user and changelog models.
  • Implemented support for account registration.
  • Updated user model to support password authentication out of the box.

(Redmine issue: #3443)

Revision d569580f (diff)
Added by Jan Mach 21 days ago

Redesigned web interface test suite.

  • Common features are implemented in vial.test module.
  • Common Hawat features are implemented in hawat.test module.

(Redmine issue: #1017,#3443)

Revision f5293f46 (diff)
Added by Jan Mach 21 days ago

Implemented separate unit tests for hawat.blueprints.auth_api package.

(Redmine issue: #1017,#3443)

Revision f3225c70 (diff)
Added by Jan Mach 17 days ago

Implemented separate unit tests for hawat.blueprints.auth_dev package.

(Redmine issue: #1017,#3443)

Revision f351c956 (diff)
Added by Jan Mach 17 days ago

Fix: Fixed errors in email templates.

(Redmine issue: #3443)

Revision 688a0da9 (diff)
Added by Jan Mach 15 days ago

Fixed bugs in 'auth_dev’ module, added better unit test coverage.

(Redmine issue: #3443,#1017)

Revision d05e5b99 (diff)
Added by Jan Mach 15 days ago

Implemented new base view vial.viev.BaseLoginView for all login views.

(Redmine issue: #3443)

Revision 7ec2d479 (diff)
Added by Jan Mach 15 days ago

Implemented new base view vial.viev.BaseRegistrationView for all user registration views.

(Redmine issue: #4410,#3443,#1017)

Revision 9e2437ee (diff)
Added by Jan Mach 15 days ago

Rewritten 'hawat.blueprints.auth_pwd’ module.

  • Used new vial.view.Base(Login|Registration)View base view classes.
  • Added unit tests.

(Redmine issue: #4410,#1017,#3443)

Revision ee5a81b2 (diff)
Added by Jan Mach 13 days ago

Rewritten 'hawat.blueprints.auth_env’ module.

  • Used new vial.view.Base(Login|Registration)View base view classes.
  • Added unit tests.

(Redmine issue: #4410,#1017,#3443)

Revision a3f1d70c (diff)
Added by Jan Mach 12 days ago

Unified Jinja2 templates for login and registration pages.

(Redmine issue: #3443)

Revision 35d17bf8 (diff)
Added by Jan Mach 10 days ago

Implemented module providing directional pages for all enabled login and account registration views.

Users will be able to easily choose the most appropriate login/registration option.

(Redmine issue: #3443,#1017)

Revision 15911f8a (diff)
Added by Jan Mach 7 days ago

Implemented unit tests for 'hawat.blueprints.users’ module.

(Redmine issue: #4410,#1017,#3443)

Revision c8534f18 (diff)
Added by Jan Mach 5 days ago

Improved unit tests for 'hawat.blueprints.users’ module.

  • Implemented missing tests for 'users.*_membership’ endpoints.
  • Fix: added missing confirmation dialog template.

(Redmine issue: #4410,#1017,#3443)

Revision 994d5c67 (diff)
Added by Jan Mach 4 days ago

Implemented unit tests for 'hawat.blueprints.groups’ module.

(Redmine issue: #4410,#1017,#3443)

Revision ca1b97f6 (diff)
Added by Jan Mach 3 days ago

Implemented unit tests for 'hawat.blueprints.filters’ module.

(Redmine issue: #4410,#1017,#3443)

Revision 200cc5f8 (diff)
Added by Jan Mach 3 days ago

Implemented unit tests for 'hawat.blueprints.networks’ module.

(Redmine issue: #4410,#1017,#3443)

Revision 1f0fc32b (diff)
Added by Jan Mach 3 days ago

Fix: Corrected unit test docstrings.

(Redmine issue: #3443,#1017)

Revision 36cc6d0c (diff)
Added by Jan Mach 3 days ago

Implemented unit tests for 'hawat.blueprints.devtools’ module.

(Redmine issue: #4410,#1017,#3443)

Revision 984ea76d (diff)
Added by Jan Mach 3 days ago

Implemented unit tests for 'hawat.blueprints.home’ module.

(Redmine issue: #4410,#1017,#3443)

Revision 94eb8061 (diff)
Added by Jan Mach 3 days ago

Fix: Fixed issue in 'auth_api’ module after upgrading flask_login to 0.5.0.

In previous version it was necessary to manually signal flask principal about identity change. Now it is not necessary anymore, it even results in infinite recursion loop.

(Redmine issue: #3443,#1017,#3387)

Revision 933b3eec (diff)
Added by Jan Mach 2 days ago

Improved coding style and fixed minor issues in mentat.reports.base module.

(Redmine issue: #3443)

Revision b29f7a50 (diff)
Added by Jan Mach 2 days ago

Implemented unit tests for 'hawat.blueprints.changelogs’ module.

Also removed unnecessary docstrings.

(Redmine issue: #4410,#1017,#3443)

Revision 1bc38f7d (diff)
Added by Jan Mach 2 days ago

Implemented unit tests for 'hawat.blueprints.dbstatus’ module.

Also removed unnecessary docstrings.

(Redmine issue: #4410,#1017,#3443)

Revision 6573c18b (diff)
Added by Jan Mach 2 days ago

Implemented unit tests for 'hawat.blueprints.dnsr’ module.

Also removed unnecessary docstrings.

(Redmine issue: #4410,#1017,#3443)

Revision bbd2fa7e (diff)
Added by Jan Mach 2 days ago

Implemented unit tests for 'hawat.blueprints.events’ module.

Also removed unnecessary docstrings.

(Redmine issue: #4410,#1017,#3443)

Revision a4e0837b (diff)
Added by Jan Mach 2 days ago

Implemented unit tests for 'hawat.blueprints.geoip’ module.

Also removed unnecessary docstrings.

Redmine issue: #4410,#1017,#3443)

Revision 34e8cb80 (diff)
Added by Jan Mach 2 days ago

Implemented unit tests for 'hawat.blueprints.hosts’ module.

Also removed unnecessary docstrings.

Redmine issue: #4410,#1017,#3443)

Revision 0dedd4ce (diff)
Added by Jan Mach 2 days ago

Implemented unit test skeleton for 'hawat.blueprints.nerd’ module.

Also removed unnecessary docstrings.

Redmine issue: #4410,#1017,#3443)

Revision bf269212 (diff)
Added by Jan Žerdík 1 day ago

Fixed renamed method.

(Redmine issue: #3443)

Revision aa47d70e (diff)
Added by Jan Mach about 15 hours ago

Implemented unit test skeleton for 'hawat.blueprints.pdnsr’ module.

Also removed unnecessary docstrings.

Redmine issue: #4410,#1017,#3443)

History

#1 Updated by Jan Mach over 1 year ago

  • Description updated (diff)

#2 Updated by Jan Mach over 1 year ago

  • Related to Bug #4116: INSERT statement in eventstorage,py contains redundant whitespace added

Also available in: Atom PDF