Project

General

Profile

Actions

Feature #5066

open

Warden should maybe check for duplicate IDEA message identifiers

Added by Jan Mach over 3 years ago. Updated about 3 years ago.

Status:
New
Priority:
Normal
Assignee:
Category:
Server
Target version:
-
Start date:
05/14/2019
Due date:
% Done:

0%

Estimated time:

Description

Due to performance reasons Warden currently does not seem to check for duplicate message identifiers. Maybe it should enforce the IDEA schema requirement for these IDs to be unique.

Actions #1

Updated by Pavel Kácha about 3 years ago

  • Subject changed from Warden should maybe check for duplicit IDEA message identifiers to Warden should maybe check for duplicate IDEA message identifiers
Actions #2

Updated by Pavel Kácha about 3 years ago

  • Assignee changed from Warden to Pavel Kácha

Kind request for advice. This might be the low hanging fruit, however it may affect performance. Radko, do you think simple adding idea_id TINYTEXT with UNIQUE constraint into EVENTS table fits the bill? Or would you have any other idea? (Note we're talking MySQL here. )

Actions #3

Updated by Radko Krkoš about 3 years ago

Pavel Kácha wrote:

Kind request for advice. This might be the low hanging fruit, however it may affect performance. Radko, do you think simple adding idea_id TINYTEXT with UNIQUE constraint into EVENTS table fits the bill? Or would you have any other idea? (Note we're talking MySQL here. )

That is the approach I would use with PostgreSQL. A quick search shows that the implementation and mechanics are very similar in both [1], so this really might be a low hanging fruit.
Note that editing the schema will only work with new installations, for existing you need the "ALTER TABLE ... ADD CONSTRAINT ... UNIQUE (column);" version.

[1] http://www.mysqltutorial.org/mysql-unique-constraint/

Actions

Also available in: Atom PDF