Feature #5066
closedWarden should maybe check for duplicate IDEA message identifiers
100%
Description
Due to performance reasons Warden currently does not seem to check for duplicate message identifiers. Maybe it should enforce the IDEA schema requirement for these IDs to be unique.
Updated by Pavel Kácha about 5 years ago
- Subject changed from Warden should maybe check for duplicit IDEA message identifiers to Warden should maybe check for duplicate IDEA message identifiers
Updated by Pavel Kácha about 5 years ago
- Assignee changed from Warden to Pavel Kácha
Kind request for advice. This might be the low hanging fruit, however it may affect performance. Radko, do you think simple adding idea_id TINYTEXT with UNIQUE constraint into EVENTS table fits the bill? Or would you have any other idea? (Note we're talking MySQL here. )
Updated by Radko Krkoš about 5 years ago
Pavel Kácha wrote:
Kind request for advice. This might be the low hanging fruit, however it may affect performance. Radko, do you think simple adding idea_id TINYTEXT with UNIQUE constraint into EVENTS table fits the bill? Or would you have any other idea? (Note we're talking MySQL here. )
That is the approach I would use with PostgreSQL. A quick search shows that the implementation and mechanics are very similar in both [1], so this really might be a low hanging fruit.
Note that editing the schema will only work with new installations, for existing you need the "ALTER TABLE ... ADD CONSTRAINT ... UNIQUE (column);" version.
Updated by Pavel Kácha over 1 year ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset b24a893f0d7ea1fcdacdafaff259d181b408e21d.