Project

General

Profile

Actions

Bug #6191

closed

Implement thread safety in eventstorage service module

Added by Jan Mach over 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Development - Database
Target version:
Start date:
01/14/2020
Due date:
% Done:

100%

Estimated time:
To be discussed:
No

Description

While working on #4384 I have come across several peculiar issues that have led me to conclusion, that something is amiss in the implementation of eventstorage service and generally with implementation of event database access from Flask application directly via psycopg2.

I have found out that it is indeed not implemented in thread-safe manner.


Related issues

Related to Mentat - Bug #4384: Possibility of DoS by repeating long queryClosedJan Mach10/19/2018

Actions
Blocks Mentat - Bug #7590: /api/events/search sometimes crashes with TypeError: Expected 22 arguments, got 23ClosedRajmund Hruška06/06/2022

Actions
Blocks Mentat - Bug #7565: Timeline falls flat on certain queryClosed03/02/2022

Actions
Actions #1

Updated by Jan Mach over 4 years ago

  • Related to Bug #4384: Possibility of DoS by repeating long query added
Actions #2

Updated by Pavel Kácha over 4 years ago

Let's solve by configuration+doc - if using Apache, use process based MPM, if WSGI, configure no threading.

If lack of threading bites us in the future, we'll go for more thorough solution.

Actions #3

Updated by Pavel Kácha over 4 years ago

  • To be discussed changed from Yes to No
Actions #4

Updated by Jan Mach over 4 years ago

  • Target version changed from 2.6 to 2.7
Actions #5

Updated by Jan Mach about 4 years ago

  • Target version changed from 2.7 to 2.8
Actions #6

Updated by Jan Mach about 4 years ago

  • Target version changed from 2.8 to Backlog
Actions #7

Updated by Pavel Kácha about 4 years ago

  • Target version changed from Backlog to Future
Actions #8

Updated by Pavel Kácha over 3 years ago

  • Assignee deleted (Jan Mach)
Actions #9

Updated by Rajmund Hruška about 2 years ago

  • Blocks Bug #7590: /api/events/search sometimes crashes with TypeError: Expected 22 arguments, got 23 added
Actions #10

Updated by Rajmund Hruška about 2 years ago

  • Status changed from New to In Progress
  • Target version changed from Future to 2.10

So, the configuration was changed on mentat-hub. The only thing to do is to write some information to the documentation, right?

Actions #11

Updated by Rajmund Hruška about 2 years ago

  • Blocks Bug #7565: Timeline falls flat on certain query added
Actions #12

Updated by Pavel Kácha about 2 years ago

Rajmund Hruska wrote in #note-10:

So, the configuration was changed on mentat-hub. The only thing to do is to write some information to the documentation, right?

Right. And maybe explicitly fix this in our ansible roles (sigh).

Actions #13

Updated by Pavel Kácha almost 2 years ago

And cuz I'm dork, I did set up mpm_worker instead of mpm_prefork. Sigh, corrected, let's watch it further.

Actions #14

Updated by Pavel Kácha almost 2 years ago

  • Assignee set to Pavel Kácha
Actions #15

Updated by Pavel Kácha almost 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
Actions #16

Updated by Pavel Kácha almost 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF