Project

General

Profile

Bug #7106

Notification mails about new users for the group do not seem to go to group admin

Added by Pavel Kácha 4 months ago. Updated 28 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Development - Core
Target version:
Start date:
03/05/2021
Due date:
% Done:

90%

Estimated time:
To be discussed:
No

Description

Happened 8. 1. 2021 with on mentat-hub, where notification mail haven't reached group managers.

#1

Updated by Jan Mach 3 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50
#2

Updated by Jan Mach 3 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 50 to 90

I have verified (sorry for the spam), that the mailing to group managers works when following conditions are met: group must have self management enabled, user must request group membership during registration. Information about mails being sent in now logged more verbosely into /var/mentat/log/mentat-hawat.py.log file.

We can make the "Requested group memberships:" field required in the registration form to prevent this from happening again, if that is desirable. Also we can remove the "self management enabled" requirement by discarding the managed column from groups table and simply always send information emails in case group has any managers set.

Should I do the aforementioned changes?

#3

Updated by Pavel Kácha 3 months ago

Jan Mach wrote in #note-2:

I have verified (sorry for the spam), that the mailing to group managers works when following conditions are met: group must have self management enabled, user must request group membership during registration. Information about mails being sent in now logged more verbosely into /var/mentat/log/mentat-hawat.py.log file.

Thanks! On the devel, or deployed on hub also?

We can make the "Requested group memberships:" field required in the registration form to prevent this from happening again, if that is desirable. Also we can remove the "self management enabled" requirement by discarding the managed column from groups table and simply always send information emails in case group has any managers set.

Should I do the aforementioned changes?

I'd NOT go for required field - sometimes it is desirable to have users, which are members of no group (707 developers, students, ...)

Discarding 'managed' column makes sense (if admin does not want to manage group, it does not have to be an admin). However, couldn't there be a clash with Žerdík's changes, which Rajmund is going to integrate (#6239)? If so, I'd wait with it.

#4

Updated by Jan Mach 3 months ago

  • To be discussed changed from No to Yes

Pavel Kácha wrote in #note-3:

Jan Mach wrote in #note-2:

I have verified (sorry for the spam), that the mailing to group managers works when following conditions are met: group must have self management enabled, user must request group membership during registration. Information about mails being sent in now logged more verbosely into /var/mentat/log/mentat-hawat.py.log file.

Thanks! On the devel, or deployed on hub also?

Only on mentat-alt. There were no major code changes, I have just added some log writes to be able to better verify the code flow. There are no code flow fixes.

We can make the "Requested group memberships:" field required in the registration form to prevent this from happening again, if that is desirable. Also we can remove the "self management enabled" requirement by discarding the managed column from groups table and simply always send information emails in case group has any managers set.

Should I do the aforementioned changes?

I'd NOT go for required field - sometimes it is desirable to have users, which are members of no group (707 developers, students, ...)

OK.

Discarding 'managed' column makes sense (if admin does not want to manage group, it does not have to be an admin). However, couldn't there be a clash with Žerdík's changes, which Rajmund is going to integrate (#6239)? If so, I'd wait with it.

No, there should not be any clashes. Žerdik`s changes are related to reporting settings contained mostly in reporting_settings table. This is a managed column in groups table, unrelated to reporting.

#5

Updated by Jan Mach 3 months ago

  • To be discussed changed from Yes to No

After the discussion we will proceed to remove managed column from groups table.

#6

Updated by Jan Mach about 2 months ago

  • Status changed from Feedback to In Progress
#7

Updated by Pavel Kácha 28 days ago

  • Target version changed from 2.8 to 2.9

Also available in: Atom PDF