Task #6239
closedSimplify/remove too detailed user settings for reporting
100%
Description
We suspect that multitude of user configuration knobs for reporting is not used, also, it complicates incorporation of new algorithms (especially reporting to more groups in one mail - To+Cc differentiation).
We need to review the group settings - how many are changed far from default, how, and for which groups and then consider finding reasonable systemwide defaults and possible removing some altogether.
Related issues
Updated by Pavel Kácha over 4 years ago
- Related to Feature #6227: Incorporate new info from Negistry into group db and reporting added
Updated by Pavel Kácha over 4 years ago
After review and discussion:
- template - visible and settable only by admin
- reporting timing - systemwide config only
- attachment size limit + compression + formats - let's get rid of attachments altogether, leave only link for download from web. As it will need some communication to users, let's track in separate ticket #6255.
- as for locale and timestamps, still open for discussion, possibilities are:
- leave as is (in reports to multiple recipients use the most specific one, others tough luck) - good for working with timestamps for local people
- make reports bilingual
- make reports english
Updated by Pavel Kácha over 4 years ago
- Related to Feature #6255: Move attachments from emails to web added
Updated by Pavel Kácha over 4 years ago
Pavel Kácha wrote:
- as for locale and timestamps, still open for discussion, possibilities are:
- leave as is (in reports to multiple recipients use the most specific one, others tough luck) - good for working with timestamps for local people
- make reports bilingual
- make reports english
After discussion - let's leave as is, we chose by most specific settings.
Updated by Pavel Kácha over 4 years ago
Mute + Redirect must stay per group for debugging, but only changeable by admin.
(And also reporting mode, changeable by group.)
Updated by Pavel Kácha over 4 years ago
- Related to deleted (Feature #6255: Move attachments from emails to web)
Updated by Pavel Kácha over 4 years ago
- Blocked by Feature #6255: Move attachments from emails to web added
Updated by Jan Mach over 4 years ago
- Target version changed from Backlog to 2.8
Updated by Pavel Kácha almost 4 years ago
- Target version changed from 2.8 to 2.9
Updated by Pavel Kácha over 3 years ago
- Assignee changed from Jan Žerdík to Rajmund Hruška
Due to personal changes this haven't reached devel correctly, so we need to merge d282e3a0 (and nothing after) and put #6227 work on top of that.
Updated by Pavel Kácha over 3 years ago
- make redirect setting unreachable/invisible for users
- (maybe change it to explicit email field instead of boolean dependent on some setting in configuration)
- or remove it altogether (admin can always change target address - however that is visible to user then)
Updated by Rajmund Hruška over 3 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
There are currently 43 groups where redirect is set to true, so I chose not to remove this setting. I changed the redirect setting to be only visible and settable by admin.
Other than that, I think that this task is done. The code is merged in the branch used for #6227.
Updated by Rajmund Hruška over 3 years ago
- Status changed from Resolved to Feedback
- To be discussed set to Yes
- template was removed completely. I mentioned that during one of the meetings and I think that it is fine. Correct me if I am wrong.
- mute is still visible to everyone in the group and changeable by the group manager. Is that OK or should it only be changeable by admin as it was written in #note-5?
Updated by Pavel Kácha over 3 years ago
Rajmund Hruska wrote in #note-17:
I read the previous comments more carefully and I realized that:
- template was removed completely. I mentioned that during one of the meetings and I think that it is fine. Correct me if I am wrong.
Agreed.
- mute is still visible to everyone in the group and changeable by the group manager. Is that OK or should it only be changeable by admin as it was written in #note-5?
Admin can use redirect instead of mute, at he will be bothered by mails to solve the real problem.
Updated by Rajmund Hruška over 3 years ago
- Status changed from Feedback to In Progress
- % Done changed from 100 to 80
- To be discussed deleted (
Yes)
Pavel Kácha wrote in #note-18:
Rajmund Hruska wrote in #note-17:
I read the previous comments more carefully and I realized that:
- template was removed completely. I mentioned that during one of the meetings and I think that it is fine. Correct me if I am wrong.
Agreed.
- mute is still visible to everyone in the group and changeable by the group manager. Is that OK or should it only be changeable by admin as it was written in #note-5?
Admin can use redirect instead of mute, at he will be bothered by mails to solve the real problem.
I will remove the mute option.
Updated by Rajmund Hruška over 3 years ago
- Status changed from In Progress to Resolved
- % Done changed from 80 to 100
I removed the mute option in 1b64ae46, in the hruska-feature-#6227-negistry branch.
Updated by Rajmund Hruška about 3 years ago
- Status changed from Resolved to In Review
Merged into devel.
Updated by Radko Krkoš about 3 years ago
The removal of 'mute' option was not clean, some leftovers remained.
Log from mentat-alt:
Traceback (most recent call last):
File "/usr/local/bin/mentat-reporter.py", line 51, in <module>
MentatReporterScript().run()
File "/var/mentat/venv/lib/python3.7/site-packages/pyzenkit/baseapp.py", line 1556, in run
self._stage_process()
File "/var/mentat/venv/lib/python3.7/site-packages/pyzenkit/baseapp.py", line 1469, in _stage_process
self._sub_stage_process()
File "/var/mentat/venv/lib/python3.7/site-packages/pyzenkit/zenscript.py", line 353, in _sub_stage_process
self.execute_script_command(cmdname)
File "/var/mentat/venv/lib/python3.7/site-packages/pyzenkit/zenscript.py", line 410, in execute_script_command
self.runlog[command_name] = cbk() # pylint: disable=locally-disabled,not-callable
File "/var/mentat/venv/lib/python3.7/site-packages/mentat/module/reporter.py", line 375, in cbk_command_report
time_h
File "/var/mentat/venv/lib/python3.7/site-packages/mentat/module/reporter.py", line 441, in _report_for_group
self.c(self.CONFIG_TEST_DATA)
File "/var/mentat/venv/lib/python3.7/site-packages/mentat/reports/event.py", line 225, in report
report_summary = self.report_summary(result, events, abuse_group, settings, severity, time_l, time_h, template_vars, testdata)
File "/var/mentat/venv/lib/python3.7/site-packages/mentat/reports/event.py", line 288, in report_summary
if not settings.mute and settings.mode in (mentat.const.REPORTING_MODE_SUMMARY, mentat.const.REPORTING_MODE_BOTH):
AttributeError: 'ReportingSettings' object has no attribute 'mute'
Fails during the run of the reporter, so every 10 minutes.
Updated by Rajmund Hruška about 3 years ago
Radko Krkoš wrote in #note-22:
The removal of 'mute' option was not clean, some leftovers remained.
Log from
mentat-alt:
[...]Fails during the run of the reporter, so every 10 minutes.
I missed one line of code when resolving conflicts. I fixed the issue, enabled the reporter and it seems to be working now.
Updated by Radko Krkoš about 3 years ago
Rajmund Hruska wrote in #note-23:
Radko Krkoš wrote in #note-22:
The removal of 'mute' option was not clean, some leftovers remained.
Log from
mentat-alt:
[...]Fails during the run of the reporter, so every 10 minutes.
I missed one line of code when resolving conflicts. I fixed the issue, enabled the reporter and it seems to be working now.
Very well. Good job.
Updated by Pavel Kácha over 2 years ago
- Status changed from In Review to Closed