Project

General

Profile

Actions

Bug #7365

open

Buildbot warnings on mentat-deb

Added by Radko Krkoš 2 months ago. Updated about 1 month ago.

Status:
Feedback
Priority:
Normal
Assignee:
Category:
Design
Target version:
Start date:
05/26/2021
Due date:
% Done:

100%

Estimated time:
To be discussed:
Yes

Description

On every run of buildbot, warnings are reported through emails. The warnings are from debian's lintian during .deb build. As was discussed before, this creates noise that can make real bugs slip through and so should be fixed, so that build warnings could be relied upon and not ignored.


Related issues

Related to Mentat - Bug #7377: Warnings by pyflakes on buildFeedbackJan Mach05/28/2021

Actions
Actions #1

Updated by Radko Krkoš 2 months ago

  • Assignee changed from Radko Krkoš to Jan Mach
  • % Done changed from 0 to 50
  • To be discussed changed from No to Yes

The required changes are in repository in the branch source:@krkos-bug-#7365-buildbot-lintian-warnings. The lintian is happy on local build. It was not tested with buildbot, it must be pushed into {release,devel,master} branch for that, which should not be done yet.
Most of the changes are obvious, but commit 1153bea3fe7dc3f585518e8876ff9ff439bc7284 should be checked by Mek, so reassigning to him.

Actions #2

Updated by Jan Mach 2 months ago

  • % Done changed from 50 to 100

Radko Krkoš wrote in #note-1:

The required changes are in repository in the branch source:@krkos-bug-#7365-buildbot-lintian-warnings. The lintian is happy on local build. It was not tested with buildbot, it must be pushed into {release,devel,master} branch for that, which should not be done yet.
Most of the changes are obvious, but commit 1153bea3fe7dc3f585518e8876ff9ff439bc7284 should be checked by Mek, so reassigning to him.

Great job Radko. I think the best way to go with the Bootstrap CSS file is to do it the way you did it. Since the package is being updated during the time maintenance mode is on, there could be some potential problems if it used the CSS file from Hawat package. One more minified file is not that much of an extra weight and above all, it is dead simple, there will be no surprises ever.

Actions #3

Updated by Radko Krkoš 2 months ago

  • Related to Bug #7377: Warnings by pyflakes on build added
Actions #4

Updated by Radko Krkoš 2 months ago

  • Status changed from New to In Review
Actions #5

Updated by Pavel Kácha about 1 month ago

  • Status changed from In Review to Feedback
Actions

Also available in: Atom PDF