Project

General

Profile

Actions

Bug #7377

closed

Warnings by pyflakes on build

Added by Radko Krkoš over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Design
Target version:
Start date:
05/28/2021
Due date:
% Done:

100%

Estimated time:
To be discussed:

Description

Buildbot reports some pyflakes warnings currently, but does not react to them either by e-mail or build failure. All the current warnings are reasonable and should be fixed and pyflakes's output can then be honored.


Related issues

Related to Mentat - Bug #7365: Buildbot warnings on mentat-debClosedJan Mach05/26/2021

Actions
Actions #1

Updated by Radko Krkoš over 3 years ago

  • Related to Bug #7365: Buildbot warnings on mentat-deb added
Actions #2

Updated by Radko Krkoš over 3 years ago

  • Assignee changed from Radko Krkoš to Jan Mach
  • % Done changed from 0 to 30
  • To be discussed changed from No to Yes

The code, which pyflakes complained about was analyzed, proposed fixes are in the repository branch source:@krkos-bug-#7377-pyflakes-fixes. Please review.

Also, once is merged, the CI should be set up to honor the output of pyflakes, which I presume is done on alchemist.cesnet.cz, in configuration (I do not have access rights there).

Actions #3

Updated by Radko Krkoš over 3 years ago

  • Status changed from New to In Review
Actions #4

Updated by Pavel Kácha over 3 years ago

  • Status changed from In Review to Feedback
Actions #5

Updated by Jan Mach over 3 years ago

  • % Done changed from 30 to 80

Looks good, thank you Radko.

Actions #6

Updated by Pavel Kácha over 3 years ago

Seems these warnings are not sent by mail (unlike #7365), Mek, could you please look into it?

Actions #7

Updated by Pavel Kácha over 3 years ago

  • To be discussed deleted (Yes)
Actions #8

Updated by Radko Krkoš over 3 years ago

  • Target version changed from Backlog to 2.9

Merged into devel. The e-mail notifications still have to be set up on alchemist.

Actions #9

Updated by Jan Mach about 3 years ago

I have reconfigured Alchemist builds to fail CHECK step on any Pyflakes errors. I think that this task can now be considered done, we can however keep the issue open for some time to further test the correct behavior of the build system.

Actions #10

Updated by Jan Mach about 3 years ago

  • % Done changed from 80 to 100
Actions #11

Updated by Jan Mach about 3 years ago

  • To be discussed set to Yes
Actions #12

Updated by Jan Mach about 3 years ago

  • Status changed from Feedback to Resolved
Actions #13

Updated by Pavel Kácha about 3 years ago

  • Status changed from Resolved to Closed
Actions #14

Updated by Pavel Kácha about 3 years ago

  • To be discussed deleted (Yes)
Actions

Also available in: Atom PDF