Bug #7377
closed
Warnings by pyflakes on build
Added by Radko Krkoš over 3 years ago.
Updated about 3 years ago.
Description
Buildbot reports some pyflakes warnings currently, but does not react to them either by e-mail or build failure. All the current warnings are reasonable and should be fixed and pyflakes's output can then be honored.
- Related to Bug #7365: Buildbot warnings on mentat-deb added
- Assignee changed from Radko Krkoš to Jan Mach
- % Done changed from 0 to 30
- To be discussed changed from No to Yes
The code, which pyflakes complained about was analyzed, proposed fixes are in the repository branch source:@krkos-bug-#7377-pyflakes-fixes. Please review.
Also, once is merged, the CI should be set up to honor the output of pyflakes, which I presume is done on alchemist.cesnet.cz, in configuration (I do not have access rights there).
- Status changed from New to In Review
- Status changed from In Review to Feedback
- % Done changed from 30 to 80
Looks good, thank you Radko.
Seems these warnings are not sent by mail (unlike #7365), Mek, could you please look into it?
- To be discussed deleted (
Yes)
- Target version changed from Backlog to 2.9
Merged into devel. The e-mail notifications still have to be set up on alchemist.
I have reconfigured Alchemist builds to fail CHECK step on any Pyflakes errors. I think that this task can now be considered done, we can however keep the issue open for some time to further test the correct behavior of the build system.
- % Done changed from 80 to 100
- To be discussed set to Yes
- Status changed from Feedback to Resolved
- Status changed from Resolved to Closed
- To be discussed deleted (
Yes)
Also available in: Atom
PDF