Task #7494
closedFix skipped/broken unit tests
100%
Description
Related issues
Updated by Rajmund Hruška about 3 years ago
- Blocked by Bug #7466: Viewing details of abuse group in reports/dashboard results in internal server error added
Updated by Rajmund Hruška about 3 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 70
In the last couple of days I have been trying to fix the skipped tests. I found out that I don't really know the purpose of vial
, it seems to have the same functionality as hawat
.
There is still one test marked to be skipped, it's lib/vial/blueprints/auth_api/test/__init__.py
. I think I managed to fix a couple of tests, though.
Also, there are some tests which for some reason are not tested with make tests
command. For example, lib/vial/blueprints/groups/test/__init__.py
contains a test which results in error (the error is solved in #7466), but when running make tests
this error never appears.
Updated by Rajmund Hruška over 2 years ago
- Status changed from In Progress to Feedback
- To be discussed changed from No to Yes
In one of the meetings, we talked about removing/merging vial
and Jan Mach said he will do it. All of the skipped tests are in vial
. Should I try fixing those tests before the merge is done?
Updated by Pavel Kácha over 2 years ago
- Assignee changed from Rajmund Hruška to Jan Mach
Rajmund Hruska wrote in #note-3:
In one of the meetings, we talked about removing/merging
vial
and Jan Mach said he will do it. All of the skipped tests are invial
. Should I try fixing those tests before the merge is done?
If all of them are from Vial, it's task for Vial merging (I guess at #7544 Mek will decide, whether those tests have their opposite in Hawat, or should be adapted, or should be ditched).
Updated by Pavel Kácha over 2 years ago
- Related to Task #7544: Resect Vial added
Updated by Rajmund Hruška about 2 years ago
- Category set to Testing
- Status changed from Feedback to Resolved
- Assignee changed from Jan Mach to Rajmund Hruška
- Target version changed from Backlog to 2.10
- % Done changed from 70 to 100
Updated by Rajmund Hruška about 2 years ago
- Status changed from Resolved to Closed
All tests passed on Buildbot.