Project

General

Profile

Actions

Bug #7561

closed

Inconsistent quotation in YAML representation of event

Added by Radko Krkoš over 2 years ago. Updated 5 months ago.

Status:
Rejected
Priority:
Low
Assignee:
-
Category:
Development - GUI
Target version:
Start date:
02/16/2022
Due date:
% Done:

0%

Estimated time:
To be discussed:
No

Description

In the "YAML data" view of event details, various attribute values are quoted inconsistently. Generally, the values are not quoted, including strings with whitespace. Then there are exceptions - the datetimes are (always) quoted, some IPv6 addresses are quoted (while others are not) and some of the country codes are quoted. Here is an example:
https://mentat-hub.cesnet.cz/mentat/events/18626-PDNS-22704-2022047-30505-CRYPTO-24637-14489-31809/show#tab-event-data-yaml

Is there anything special about Norway?


Related issues

Related to Mentat - Feature #7678: Better event viewClosedJakub Judiny09/26/2023

Actions
Actions #1

Updated by Radko Krkoš over 2 years ago

  • Category set to Development - GUI
Actions #2

Updated by Pavel Kácha over 2 years ago

Radko Krkoš wrote:

Is there anything special about Norway?

Actually yes. YAML accepts 'yes' ano 'no' as booleans...

Actions #3

Updated by Radko Krkoš over 2 years ago

OK, putting quotes around all strings might be against the spirit of YAML. There goes the Norway case and the IPv6s. That leaves the timestamps which are valid [1] in YAML and do not need to be strings.

[1] https://yaml.org/type/timestamp.html

Actions #4

Updated by Pavel Kácha over 2 years ago

Aaand just a note - afaik YAML view was just a hack to better view the whole Idea event where default view does not suffice and JSON is quite unreadable. So I'd suggest not jumping into solving this issue, but rather extending default ("nice") Idea view to actually NOT hide unusual things and making it more usable. (And then get rid of YAML view altogether.)

Actions #5

Updated by Pavel Kácha about 2 years ago

AFAIK YAML was added just for convenience - another view for human (something aking less curly JSON). I guess we should streamline/enhance main view of the event (so there is minimal incentive for user to go for JSON/YAML) and get rid of YAML altogether.

Actions #6

Updated by Pavel Kácha 9 months ago

Actions #7

Updated by Rajmund Hruška 5 months ago

  • Status changed from New to Rejected

We got rid of YAML in #7678.

Actions #8

Updated by Rajmund Hruška 5 months ago

  • Target version changed from Backlog to Rejected
Actions

Also available in: Atom PDF