Bug #7587
closed
Added by Rajmund Hruška over 2 years ago.
Updated over 2 years ago.
Description
There are 2 parts of this issue:
1. Fix existing deprecation warnings
2. Automatically check and report deprecation warnings
- Related to Bug #7583: Report feedback not working added
- Status changed from In Progress to Feedback
- To be discussed changed from No to Yes
There is a bunch of these deprecation warnings:
/vagrant/lib/hawat/base.py:636: DeprecationWarning: 'jinja2.Markup' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.Markup' instead.
self.config.get('ICONS').get(default_icon)
/vagrant/lib/hawat/view/__init__.py:1846: DeprecationWarning: 'jinja2.Markup' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.Markup' instead.
flask.Markup(self.get_message_success(item = item, parent = parent)),
So, we are using
Markup
from
flask
which is deprecated.
flask
fixed this warning (and a bunch of other warnings) in version
2.0.0
. We are using version
1.1.1
, so I suggest moving to the latest version (which is
2.1.2
).
Regarding the second part of this issue, I would go with the solution described at https://stackoverflow.com/questions/59680450/how-to-detect-compiler-warnings-in-gitlab-ci. It won't produce any emails but on GitLab it will be visible that there are some warnings.
- Status changed from Feedback to In Progress
- Target version changed from Backlog to 2.10
- % Done changed from 0 to 20
- To be discussed deleted (
Yes)
- Status changed from In Progress to Resolved
- % Done changed from 20 to 100
Also, regarding checking the deprecation warnings - the mechanism will be implemented in GitLab CI/CD with #7539.
- Status changed from Resolved to In Review
Merged into devel and deployed on mentat-alt
.
- Status changed from In Review to Closed
Also available in: Atom
PDF