Project

General

Profile

Actions

Feature #4726

closed

Possibility of notification of reporting filter or limits change

Added by Pavel Kácha over 5 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Development - Tools
Target version:
Start date:
02/11/2019
Due date:
% Done:

90%

Estimated time:
To be discussed:
No

Description

Top level security team (possibly running Mentat) should be able to know and review if admin of some group is setting up new filter or changing some, or if he is softening reporting limits. Mail notification might be sufficient.


Related issues

Related to Mentat - Bug #7582: Group admins are not able to create new reporting filtersClosedRajmund Hruška05/03/2022

Actions
Related to Mentat - Bug #7687: Any operation with filter shows message that it was unsuccessful (in dev)ClosedJakub Judiny10/25/2023

Actions
Related to Mentat - Bug #7721: The email about filter change doesn't have a Czech translation ClosedRajmund Hruška03/21/2024

Actions
Related to Mentat - Bug #7741: Link to filter details in email about filter change should not be displayed when the filter was deletedIn ReviewRajmund Hruška05/22/2024

Actions
Actions #1

Updated by Pavel Kácha over 4 years ago

Maybe related to #3367?

Actions #2

Updated by Pavel Kácha over 3 years ago

  • Assignee deleted (Jan Mach)
Actions #3

Updated by Pavel Kácha about 2 years ago

  • Related to Bug #7582: Group admins are not able to create new reporting filters added
Actions #4

Updated by Rajmund Hruška about 1 year ago

The limits are no longer relevant.

We should send the changelog of filter to group admins and maintainers.

Actions #5

Updated by Rajmund Hruška 10 months ago

  • Assignee set to Rajmund Hruška
  • Target version changed from Backlog to 2.12
Actions #6

Updated by Rajmund Hruška 10 months ago

  • Status changed from New to In Progress
Actions #7

Updated by Rajmund Hruška 10 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

So far, the sent email looks like this:

Dear group manager,

filter "Filter Queeg" of group "DEMO_GROUP" was just updated in Mentat. Here is
the difference:

    ---

    +++

    @@ -1,7 +1,7 @@

     {
         "categories": [],
         "createtime": "2023-08-25 11:44:28.843849",
    -    "description": "Filter out all messages originating from
    cz.cesnet.queeg detection node",
    +    "description": "Filter out all messages originating from
    cz.cesnet.queeg detection node and some more text",
         "detectors": [],
         "enabled": false,
         "filter": "Node.Name == \"cz.cesnet.queeg\"",
    @@ -12,6 +12,6 @@

         "name": "Filter Queeg",
         "sources": [],
         "type": "advanced",
    -    "valid_from": "None",
    +    "valid_from": "2023-08-25 14:19:39",
         "valid_to": "None" 
     }

Details of the filter can be found here:

  https://localhost:4443/mentat/filters/1/show

Have a nice day

-- Mentat

Feel free to suggest improvements.

Also, I didn't make translations. We should translate all before releasing version 2.12.

Actions #8

Updated by Jakub Judiny 10 months ago

Rajmund Hruška wrote in #note-7:

So far, the sent email looks like this:

[...]

Feel free to suggest improvements.

Also, I didn't make translations. We should translate all before releasing version 2.12.

I have two suggestions:
1. Do not send the email to the author of the change
2. It would be great to mention who changed the filter, maybe even if it was a Mentat maintainer or a group manager

Actions #9

Updated by Rajmund Hruška 9 months ago

  • Status changed from Resolved to In Review
Actions #10

Updated by Rajmund Hruška 9 months ago

  • Status changed from In Review to In Progress
Actions #11

Updated by Rajmund Hruška 9 months ago

  • % Done changed from 100 to 90
Actions #12

Updated by Jakub Judiny 8 months ago

  • Related to Bug #7687: Any operation with filter shows message that it was unsuccessful (in dev) added
Actions #13

Updated by Rajmund Hruška 7 months ago

  • Status changed from In Progress to In Review
Actions #14

Updated by Rajmund Hruška 3 months ago

  • Status changed from In Review to Closed
Actions #15

Updated by Rajmund Hruška 3 months ago

  • Related to Bug #7721: The email about filter change doesn't have a Czech translation added
Actions #16

Updated by Rajmund Hruška 28 days ago

  • Related to Bug #7741: Link to filter details in email about filter change should not be displayed when the filter was deleted added
Actions

Also available in: Atom PDF